From owner-svn-ports-head@freebsd.org  Sat May 14 09:59:36 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E159B3A48D;
 Sat, 14 May 2016 09:59:36 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 149AF1381;
 Sat, 14 May 2016 09:59:36 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 1320E1F26; Sat, 14 May 2016 09:59:36 +0000 (UTC)
Date: Sat, 14 May 2016 09:59:36 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Baptiste Daroussin <bapt@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r415135 - in head/editors/gate: . files
Message-ID: <20160514095935.GA29838@FreeBSD.org>
References: <201605131901.u4DJ1R4h060511@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201605131901.u4DJ1R4h060511@repo.freebsd.org>
User-Agent: Mutt/1.6.0 (2016-04-01)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 May 2016 09:59:36 -0000

On Fri, May 13, 2016 at 07:01:27PM +0000, Baptiste Daroussin wrote:
> New Revision: 415135
> URL: https://svnweb.freebsd.org/changeset/ports/415135
> 
> Log:
>   Prevent collision with getline(3)
> ...
> --- head/editors/gate/Makefile	Fri May 13 18:59:03 2016	(r415134)
> +++ head/editors/gate/Makefile	Fri May 13 19:01:27 2016	(r415135)
> @@ -15,6 +15,7 @@ RUN_DEPENDS=	aspell:textproc/aspell
>  
>  USES=		ncurses
>  GNU_CONFIGURE=	yes
> +USE_CSTD=	gnu89

Was this change indented?

> --- head/editors/gate/files/patch-configure	Fri May 13 18:59:03 2016	(r415134)
> +++ head/editors/gate/files/patch-configure	Fri May 13 19:01:27 2016	(r415135)
> @@ -9,3 +9,12 @@
>   LIBS="-l$i  $ac_func_search_save_LIBS"
>   cat > conftest.$ac_ext <<EOF
>   #line 1773 "configure"
> +@@ -2123,7 +2123,7 @@ res_datadir=`eval "echo $datadir"`
> + prefix=$gate_prefix
> + 
> + cat >> confdefs.h <<EOF
> +-#define HELP_FILE "${res_datadir}/gate.help"
> ++#define HELP_FILE "/usr/local/share/gate/gate.help"

This looks bogus: there is 's|$${res_datadir}|${DATADIR}|' ${WRKSRC}/configure
line in the port's Makefile (then again, it's probably bogus as well because
of res_datadir=`eval "echo $datadir"` line in the configure script.  (Whoever
ported it was not very careful.)

./danfe