From owner-cvs-src@FreeBSD.ORG Tue Aug 15 12:16:24 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E4C716A4DD; Tue, 15 Aug 2006 12:16:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9219C43D80; Tue, 15 Aug 2006 12:16:03 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k7FCFxWm026881; Tue, 15 Aug 2006 08:16:01 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: pyunyh@gmail.com Date: Tue, 15 Aug 2006 07:47:54 -0400 User-Agent: KMail/1.9.1 References: <200608140150.k7E1osuf005683@repoman.freebsd.org> <20060815064943.GA41815@cdnetworks.co.kr> In-Reply-To: <20060815064943.GA41815@cdnetworks.co.kr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608150747.55292.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Tue, 15 Aug 2006 08:16:02 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/1662/Tue Aug 15 04:29:25 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Matt Reimer , Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Aug 2006 12:16:24 -0000 On Tuesday 15 August 2006 02:49, Pyun YongHyeon wrote: > On Mon, Aug 14, 2006 at 01:30:37PM -0700, Matt Reimer wrote: > > On 8/13/06, Pyun YongHyeon wrote: > > >yongari 2006-08-14 01:50:54 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/em if_em.c if_em.h > > > Log: > > > Overhaul Rx path to recover from mbuf cluster allocation failure. > > > o Create one more spare DMA map for Rx handler to recover from > > > bus_dmamap_load_mbuf_sg(9) failure. > > > o Make sure to update status bit in Rx descriptors even if we failed > > > to allocate a new buffer. Previously it resulted in stuck condition > > > and em_handle_rxtx task took up all available CPU cycles. > > [snip] > > > > Is it possible that the RELENG_4 if_em driver would suffer from the > > same problems, particularly the stuck/CPU-chewing problem? > > > > I think the problem exist in RELENG_4 too. If em_get_buf() fails em(4) > exits main Rx loop but still does not update status bits in the Rx > descriptor. I think you can easily experiment the problem with > "kern.ipc.nmbclusters". Hmm, well, I've already backported a lot of the changes in RELENG_6 to em(4) in RELENG_4 at work. I've got some more stuff to backport, but then I can apply this as well and see if folks want to test it. -- John Baldwin