From nobody Sun May 3 19:59:02 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g7wZv10WBz6c0xZ for ; Sun, 03 May 2026 19:59:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g7wZv0T6Jz422V for ; Sun, 03 May 2026 19:59:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777838343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KxqC7ry/34V5O7rxAXo3/1pcZiw6o0gGUjzrW0CYBik=; b=pFhtW5OCOdHhRHtim/cPSx4HbBLMhb5at54DfeSakFojtJRvUWeW4lsamWpiJCqADY3/qS SxYSgA0lw66aHrhuNyLaqB7UVus//4lGq3kI/Xy1hYtmPFMD16m2POGvjacXE+hemssBPE ICrJcrEfZaMLKPajAEksqdt9odcam2fq3/uC8t0Wznt/vUc8NvWqtDaDr3fmNpzCLh1z7e MA97YpqVesj8OHfYTh+B5hAzg9jt3IFAYQdX3r3HwtN/a379Aw9cHpLCt3LTkpQJTj4Bc1 ClxqMBBFWmtqBT0ARIhhnhVImmQzcTOsT/O7GbiqA5xMd/X4188KWN6gmzI0gg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777838343; a=rsa-sha256; cv=none; b=A6udu9/TIPK77ju41eVPwB6lG4lH65TwCq6hnCRFM18UqxOHT6d2oZM6FtnP8J94ga48Z0 VazA1/GAxCMqFy0d434Ei/SFDBXNLgUsP4Ysqwg7IK1Ir5az2NoNqsobEnamc927PswQwt MwW7UlEfLh1Ler7jCVeeUJkOieQT4eNgfKvAQ4W1kYPn0Ar2uPJrK8oKz45Z82OHLocEOC B69K5KzVBC8a0bAqNiyrHIcxwXxq7xCGn/dY4OKOKpidc8CNrAqQbPREapL+gUfoXOuueV YQ9T/aqR4TJyQeAwc5Vo9uAhIbxF5Gviw+wA/zIPsRy50y08vza93siekd2IKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777838343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KxqC7ry/34V5O7rxAXo3/1pcZiw6o0gGUjzrW0CYBik=; b=dr4BeH40LO32FkzL4xVbePW+m+Hyv8tKHdfLQFJFGGRQGYKaus4jRRU8B6ZwHreNswDsSj xxhqh0iENr7fanzEa/KxaBqBDxIhKZzZj9KhhUsZbnGeWQVrrs+lEwtI8jDeZ83rgqMD/e QH/BH5phefXiXme4mH7Ac66XocP5T/aBHyRiXC7+rb912qkKcWqN1YhSvBXXW8G1mDMMkA 4Kqalq4jX1JkURE4Z5pj+QfapC3LQyFDdvdtjyYyCBYyLuUzwnt2F6HZAvgSaYBPiWEE38 8Go0eDiZtqa0/Yhb9c29kHmYRp+bQV8mQzcW6p3UgtOvL4J4Hek6MRsHHHECsw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g7wZt6sRxzn8f for ; Sun, 03 May 2026 19:59:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 406c0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 03 May 2026 19:59:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: fbecfc4aa028 - main - fdescfs: do not change vnode type on VOP_GETATTR() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fbecfc4aa028964f972a0457809aa041d415f61b Auto-Submitted: auto-generated Date: Sun, 03 May 2026 19:59:02 +0000 Message-Id: <69f7a906.406c0.5bb26524@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=fbecfc4aa028964f972a0457809aa041d415f61b commit fbecfc4aa028964f972a0457809aa041d415f61b Author: Konstantin Belousov AuthorDate: 2026-05-03 19:09:15 +0000 Commit: Konstantin Belousov CommitDate: 2026-05-03 19:58:36 +0000 fdescfs: do not change vnode type on VOP_GETATTR() There is no point to do it. The VNON type is good enough for fdescfs operations, and changing the type on stat(2) is arbitrary and does not serve much purpose, because we recalculate the returned file type on each stat(2) anyway. But setting the type to VLNK has undesired consequence of namei() trying VOP_READLINK() there, which might fail since it defer the calculation of path to vn_fullpath(). Submitted by: Mike PR: 294768 MFC after: 2 weeks --- sys/fs/fdescfs/fdesc_vnops.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/fs/fdescfs/fdesc_vnops.c b/sys/fs/fdescfs/fdesc_vnops.c index c1188c3819e7..267e80918d1b 100644 --- a/sys/fs/fdescfs/fdesc_vnops.c +++ b/sys/fs/fdescfs/fdesc_vnops.c @@ -469,7 +469,6 @@ fdesc_getattr(struct vop_getattr_args *ap) break; } - vp->v_type = vap->va_type; return (0); }