From nobody Mon Jun 15 13:12:10 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gf9WZ5QZZz6hJxK for ; Mon, 15 Jun 2026 13:12:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gf9WZ4y3Mz3ZXs for ; Mon, 15 Jun 2026 13:12:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781529130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YMM4KcflIlYgekOGicb6WCwQjz7jI6s6C1TufaQKWtE=; b=MyF2YUa5/bViL8ZcR2Nlzo8CqowxAqK2FdzV5Gm6sf0sm/dOMSiBENA/KBB0OS7sXXG0KJ V5O5lDHvrpEe7xu7jIbqzLWzKycSIXftqDnEZ3W1r2cM+JSQMc4Hr6RHABOdxRlJwFBTOP GI7Z3tHfITExjrw3DmxFcKf+CGROej9yCqeqdVbRodAHvqNDlF0rCvCtUssKdYaBqJo4/q HTxQfrEE/oXwZ28A+TJJw/QuecHbdg72nQk7Xyi6mgrfMogYlKQ9cOj070AaTX30XX19zo 9R/InVKMCUBAcFlIaeQ3JtXohRtnqIPYL4koOsZl8/T/hx/CGXXht0CBQVRFBA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781529130; a=rsa-sha256; cv=none; b=yy30bCkQ/AsdPNhkN3U+Ini2bDkOB7futQAOX1DLWbKA0s0YxhSrS0JunkGNhIxTPzve9Q O6ClV+rd4C0xySA1nOJ1xLEXXfUpQ+gbverLnsC6Mjl8HDkUBnaV4CLfsrFNFo2y54R+Ge E/LDaN1cy+saFflVAoKa0Ka+Ax5I8u7NWxPbn2GOBGlLIsNj4J2T/OFe4sM3Iwt+NRr0nr MsFJBVP4ag+UvYWnNxO1IqyZEdhmuRmpNlk7WkjMjA25xF4adZhqjvk2WpUEkCbhpBW+rl /EafV1Edn+OSfn6liVCuMiuYizGtwlYIUcf+Zc+X6Qgpy9oSGtSaBYdk4lhi6A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781529130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YMM4KcflIlYgekOGicb6WCwQjz7jI6s6C1TufaQKWtE=; b=QsOxWsB8XOEyOASVWCPb4RWVjnwHYtpcWiRrnBrxaZzcN9e84kYLfLESm22iG9uogP9nqc wCjPdu1IwBjeS5luvR5lBoEBcE6rpzUAv+wcPdpvm4SCtaXoE4dCI9psGgLar7evXhHS1I 6+iK0iuWugeceI8aY25SOMeBpSEK8e1DY0cXrL9ZKuSjd73Eh9jhIdAD0dO8Iflt+t8fCr A0bf7fx11tqy7w8G0xg6OJ5SVeszPe0e2a50pW9yR/OCW8EvqL8UiDCoHYmCytHNEHZ98H DLn28fwHRyBs6ZyEdSrWcRmkdp2scy1t+vBwhgfMtNrEqmgFSOxTKLTu/Zaa+Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gf9WZ4YfwzxHw for ; Mon, 15 Jun 2026 13:12:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3128f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 15 Jun 2026 13:12:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: 120881b48248 - stable/15 - krb5: Fix null dereference in SPNEGO token processing List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 120881b482480bbe31ff031b3d4792d1b8159d23 Auto-Submitted: auto-generated Date: Mon, 15 Jun 2026 13:12:10 +0000 Message-Id: <6a2ffa2a.3128f.45bcd2@gitrepo.freebsd.org> The branch stable/15 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=120881b482480bbe31ff031b3d4792d1b8159d23 commit 120881b482480bbe31ff031b3d4792d1b8159d23 Author: Cy Schubert AuthorDate: 2026-06-02 17:57:17 +0000 Commit: Cy Schubert CommitDate: 2026-06-15 13:11:49 +0000 krb5: Fix null dereference in SPNEGO token processing krb5 1.22.1 erroneously removed a check from get_negTokenResp() for successful decoding of the mechListMIC field. Restore the check to prevent a null pointer dereference. Commit message details obtained from upstream commit. Obtained from: Upstream commit 4ae75cded (cherry picked from commit efb5c07f91c5c11fb9bd32227ac74c2d08adf3cf) --- crypto/krb5/src/lib/gssapi/spnego/spnego_mech.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crypto/krb5/src/lib/gssapi/spnego/spnego_mech.c b/crypto/krb5/src/lib/gssapi/spnego/spnego_mech.c index 4a778364336e..1dd0f170651b 100644 --- a/crypto/krb5/src/lib/gssapi/spnego/spnego_mech.c +++ b/crypto/krb5/src/lib/gssapi/spnego/spnego_mech.c @@ -3517,6 +3517,8 @@ get_negTokenResp(OM_uint32 *minor_status, struct k5input *in, if (k5_der_get_value(&seq, CONTEXT | 0x03, &field)) { *mechListMIC = get_octet_string(&field); + if (*mechListMIC == GSS_C_NO_BUFFER) + return GSS_S_DEFECTIVE_TOKEN; /* Handle Windows 2000 duplicate response token */ if (*responseToken &&