From owner-cvs-all@FreeBSD.ORG Sat Jun 19 12:29:09 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 91F7316A4CF; Sat, 19 Jun 2004 12:29:09 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7BB8D43D39; Sat, 19 Jun 2004 12:29:09 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5JCSmvs073169; Sat, 19 Jun 2004 12:28:48 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5JCSmPZ073168; Sat, 19 Jun 2004 12:28:48 GMT (envelope-from bde) Message-Id: <200406191228.i5JCSmPZ073168@repoman.freebsd.org> From: Bruce Evans Date: Sat, 19 Jun 2004 12:28:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/i386 machdep.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jun 2004 12:29:09 -0000 bde 2004-06-19 12:28:48 UTC FreeBSD src repository Modified files: sys/i386/i386 machdep.c Log: Removed foot-shooting setting of CR0_TS in exec_setregs(). It is unnecessary because cpu_setregs() and/or npxinit() always sets CR0_TS during system initialization, and CR0_TS is set in the next statement (fpstate_drop()) if necessary after system initialization. Setting it unnecessarily was less than a pessimization since it broke the invariant that the npx can be used without an npxdna() trap if fpucurthread is non-null. The broken invariant became harmful when I added an fnclex to npxdrop(). Removed setting of CR0_MP in exec_setregs(). This was similarly unnecessary but was harmless. Updated comments (mainly by removing them). Things are simpler now that we have cpu_setregs() and don't support a math emulator or pretend to support not having either a math emulator or an npx. Removed the ifdef for avoiding setting CR0_NE in the !SMP case in cpu_setregs(). npx_probe() should reverse the setting if it wants to force IRQ13 exception handling for testing. Revision Changes Path 1.592 +7 -25 src/sys/i386/i386/machdep.c