From owner-cvs-all@FreeBSD.ORG  Fri Jan 23 13:11:14 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3C89116A4CE; Fri, 23 Jan 2004 13:11:14 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8246943DA9; Fri, 23 Jan 2004 13:10:01 -0800 (PST)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i0NL7q0B006394;
	Fri, 23 Jan 2004 13:07:52 -0800 (PST)
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i0NL7qjr006393;
	Fri, 23 Jan 2004 13:07:52 -0800 (PST)
	(envelope-from rwatson)
Message-Id: <200401232107.i0NL7qjr006393@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Fri, 23 Jan 2004 13:07:52 -0800 (PST)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/kern kern_prot.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Jan 2004 21:11:14 -0000

rwatson     2004/01/23 13:07:52 PST

  FreeBSD src repository

  Modified files:
    sys/kern             kern_prot.c 
  Log:
  Don't grab Giant in crfree(), since prison_free() no longer requires it.
  The uidinfo code appears to be MPSAFE, and is referenced without Giant
  elsewhere.  While this grab of Giant was only made in fairly rare
  circumstances (actually GC'ing on refcount==0), grabbing Giant here
  potentially introduces lock order issues with any locks held by the
  caller.  So this probably won't help performance much unless you change
  credentials a lot in an application, and leave a lot of file descriptors
  and cached credentials around.  However, it simplifies locking down
  consumers of the credential interfaces.
  
  Bumped into by: sam
  Appeased:       tjr
  
  Revision  Changes    Path
  1.180     +1 -3      src/sys/kern/kern_prot.c