From owner-svn-ports-head@freebsd.org Fri Aug 28 18:23:50 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A24B49C54FE for ; Fri, 28 Aug 2015 18:23:50 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from vfemail.net (ninezero.vfemail.net [96.30.253.190]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6FD0FE51 for ; Fri, 28 Aug 2015 18:23:49 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: (qmail 94106 invoked by uid 89); 28 Aug 2015 18:23:49 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 28 Aug 2015 18:23:49 -0000 Received: (qmail 94041 invoked by uid 89); 28 Aug 2015 18:23:31 -0000 Received: by simscan 1.3.1 ppid: 94031, pid: 94036, t: 0.0057s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 28 Aug 2015 18:23:31 -0000 Received: (qmail 19165 invoked by uid 89); 28 Aug 2015 18:23:31 -0000 Received: by simscan 1.4.0 ppid: 19097, pid: 19145, t: 7.1884s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 28 Aug 2015 18:23:24 -0000 From: Jan Beich To: Adam Weinberger Cc: svn-ports-head@freebsd.org, Baptiste Daroussin , Adam Weinberger , svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r395509 - head/mail/dovecot2 References: <201508281627.t7SGRASm062936@repo.freebsd.org> <20150828164832.GW93486@ivaldir.etoilebsd.net> <1ten-gv2d-wny@FreeBSD.org> <4D2AEA26-E3FB-4FFD-97E1-4A7B1007CA3D@adamw.org> Date: Fri, 28 Aug 2015 20:22:58 +0200 In-Reply-To: <4D2AEA26-E3FB-4FFD-97E1-4A7B1007CA3D@adamw.org> (Adam Weinberger's message of "Fri, 28 Aug 2015 11:59:16 -0600") Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2015 18:23:50 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Adam Weinberger writes: >> On 28 Aug, 2015, at 11:51, Jan Beich wrote: >> Adam Weinberger writes: >>>> On 28 Aug, 2015, at 10:48, Baptiste Daroussin wrote: >>>> On Fri, Aug 28, 2015 at 04:27:10PM +0000, Adam Weinberger wrote: >>>>> Author: adamw >>>>> Date: Fri Aug 28 16:27:09 2015 >>>>> New Revision: 395509 >>>>> URL: https://svnweb.freebsd.org/changeset/ports/395509 >>>>>=20 >>>>> Log: >>>>> Use new _VARS option helpers. Still can't remove >>>>> bsd.port.options.mk inclusion though. >>>> >>>> I see nothing that prevents from removing bsd.port.options.mk what >>>> issue do you face? >>>=20 >>> _REQUIRE=3D LOGIN >>> MYSQL_VARS=3D _REQUIRE+=3Dmysql >>> SUB_LIST+=3D REQUIRE=3D"${_REQUIRE}" >>>=20 >>> Without including b.p.o.mk, SUB_LIST gets the default ${_REQUIRE}. It >>> needs the _VARS helpers to load before ${_REQUIRE} gets fully >>> expanded. >>=20 >> What if you move initial value? >>=20 >> $ make WITH=3DMYSQL -V '${SUB_LIST:MREQUIRE*}' >> REQUIRE=3D"LOGIN mysql" > > There's a problem there with multiple options enabled, though I have > no idea why. With b.p.o.mk included it works properly. > > $ make WITH=3D"MYSQL LDAP" -V '${SUB_LIST:MREQUIRE*}' > REQUIRE=3D"LOGIN slapd" > $ make WITH=3D"MYSQL PGSQL" -V '${SUB_LIST:MREQUIRE*}' > REQUIRE=3D"LOGIN mysql" OK. Here's an ugly workaround until someone investigates. It leaves extra space behind that's maybe harmless for rcorder(8). $ make WITH=3D"MYSQL LDAP" -V '${SUB_LIST:MREQUIRE*}' REQUIRE=3D"LOGIN slapd mysql " $ make WITH=3D"MYSQL PGSQL" -V '${SUB_LIST:MREQUIRE*}' REQUIRE=3D"LOGIN mysql postgresql" Index: mail/dovecot2/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =2D-- mail/dovecot2/Makefile (revision 395518) +++ mail/dovecot2/Makefile (working copy) @@ -129,14 +129,13 @@ PORTDOCS=3D * PORTEXAMPLES=3D * =20 # Default requirement for dovecot rc script =2D_REQUIRE=3D LOGIN +_REQUIRE=3D LOGIN ${LDAP_REQUIRE} ${MYSQL_REQUIRE} ${PGSQL_REQUIRE} =20 =2DLDAP_VARS=3D _REQUIRE+=3Dslapd =2DMYSQL_VARS=3D _REQUIRE+=3Dmysql =2DPGSQL_VARS=3D _REQUIRE+=3Dpostgresql +# XXX Appending variable in SUB_LIST seems buggy +LDAP_VARS=3D LDAP_REQUIRE=3Dslapd +MYSQL_VARS=3D MYSQL_REQUIRE=3Dmysql +PGSQL_VARS=3D PGSQL_REQUIRE=3Dpostgresql =20 =2D.include =2D SUB_LIST+=3D REQUIRE=3D"${_REQUIRE}" SUB_FILES+=3D pkg-message =20 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJV4KcCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bbGoH/1q8RePG5bzbmaKeT+0EFmWd roR4VfrsHzVBRp2voqR42Th2UUCKQP3CNXpeUeq25/zzcGltLdJtXSjQDuTpkRJ/ UInWEEHivsavzRSJ5b0dX9k7cYwESOrUO+vGQncwnAhVQZ19bnH7CF4U6jWWJmBo RI749BUfznbDWExC44yz4xc/mmz1xZLJHjBTIPSSYxm8/Y2QOZp6YY2aqxi2AmoN vAI7+yDmxm+rIuhFSlsQSdOCypN0BcN570b8C5lAqfM2bst3FheiSqnigH6wcacg jbmgoeD1INS0L/iMUXrQ4lRo1QH89PxBHjVUijDKkhaG/HIRFeVAMtY7io4T44s= =tHci -----END PGP SIGNATURE----- --=-=-=--