From owner-cvs-all@FreeBSD.ORG Fri Apr 16 11:08:33 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B6EA516A4CE for ; Fri, 16 Apr 2004 11:08:33 -0700 (PDT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5EEA643D39 for ; Fri, 16 Apr 2004 11:08:33 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 26217 invoked from network); 16 Apr 2004 18:08:32 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 16 Apr 2004 18:08:32 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i3GI8Uf0001708; Fri, 16 Apr 2004 14:08:30 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Robert Watson Date: Fri, 16 Apr 2004 14:08:37 -0400 User-Agent: KMail/1.6 References: In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200404161408.37851.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: Mike Silbersack cc: src-committers@FreeBSD.org cc: Mark Murray cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/random randomdev.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Apr 2004 18:08:34 -0000 On Thursday 15 April 2004 02:54 pm, Robert Watson wrote: > On Thu, 15 Apr 2004, John Baldwin wrote: > > On Thursday 15 April 2004 03:32 am, Mike Silbersack wrote: > > > On Tue, 13 Apr 2004, John Baldwin wrote: > > > > You should drop the lock before uiomove(). If the uio can possibly > > > > reference user memory, then uiomove() will do a copyout() which can > > > > fault and thus sleep if the page is in swap. > > > > > > > > -- > > > > John Baldwin <>< http://www.FreeBSD.org/~jhb/ > > > > > > I'm going to have a similar problem in sendfile when I try to > > > de-giantify it, and I'm sure read / write will have issues as well... > > > will WITNESS catch this potential problem? > > > > Not currently. One could add a WITNESS_WARN() check to uiomove() fairly > > easily though to force witness to catch this. > > We also need to generate sleep warnings it M_TRYWAIT is passed to the mbuf > allocator, which I believe we currently don't do. Also, did we ever > re-add the sleep warning to the process tracing code? To STOPEVENT()? No.. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org