From nobody Fri Jan 9 20:17:27 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dntNm2tc1z6MK23 for ; Fri, 09 Jan 2026 20:17:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dntNl71mlz3Khr for ; Fri, 09 Jan 2026 20:17:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767989848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nA54Poiw4fQG7sTBNdaYsmnzLpLip5/hkDz23FPMGOY=; b=LzMe/k6tJknebb1fpmBMvdE1YbTZomKP1C0SX6SMKESNeCUtBDQj26Ky4IPLevbPCQpgeT F+Q+rnVj0PE45DqJXBvnbCfK2+7fgUshEAc64VIKZDh7ILJmYVsNGUDQwP5SlK0YVK7Cfv xwI1dN+K9l+C3pyEZnR5N0o7Cq5kUxHEh6AgDRIJMnrNzL+yCDZh1qmmLo7Y0sPil1Xj3z 3+mM5fa3kd8nT0XGXOgXWr+NcNLBfkS1AgAvoWnL/4/42JQFN5oMkKk/1EGCvfjEcGNw2/ KhZjppH9BjLD6HRkVoQZm4Br9dVaFp4t15mg6D3xNbDTSp1ouoWa5nuIhMFpCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767989848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nA54Poiw4fQG7sTBNdaYsmnzLpLip5/hkDz23FPMGOY=; b=C3eRCkvlFqP55D5dWDkjuTUNG6y7TEE9Wp0jt5TiUhwPzL+8owracbwtQZGU4SMy4UtEcS d+d1F2I6tE7Rkc1ApJylZoOMz9OIawCFNmOJ2EamWp2rEpu4v77rLqmrBvm3rY4L0qJTG6 lB2atTu7oDenvJCC5J61IAaKdjA3iI2Xk+Lttly7yTP4OLIXWsJ3rA5ZzU/rHlw0G9XMmp p1jXndtLf/ORH1RXU7Z1tP+VXku7BbUJEzXxQY/drCq3/5JJgmuHi7zTdzQkQpc+M8NAlB RjiCLvYHktbUtMRb0zI2cH1r5NiEW8AM9VAAPpibjRBdrDYwJ6k5UTHVYhvC2g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1767989848; a=rsa-sha256; cv=none; b=MePH4f4svlr8tYGeOoAVNLSl+SZfbdxZI597NnnrJ/oKD0ItHIl8XQYEWp8gp3uwzjTrUt hUcRjL8ylKwulUy/EXEQmI+LqySPj83ffU8JcLPvoRscwGS2xs2lpEuXR14KR3PSX2+cC9 u6zvthljJ2s3QmQfv6eZTj/Dju/F+9AUVaUTamr6K+uUoh0G+KAhahYuQYegneCVR+/Stz Rf/MqqHEQ7Go3Gu04Rnkbq8uTIS/Jta3AQvB4o6YiUnLMqgub462pKZihJO1xVzD/F2jCg 3q5pwVONcDTsnlE7nwG2iOU5KIRE8p66iQNkf+U0BvqEg/VC2X8jK7EK+r02qQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dntNl6XYsz7gc for ; Fri, 09 Jan 2026 20:17:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 8255 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 09 Jan 2026 20:17:27 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Jack Bendtsen From: Warner Losh Subject: git: 763179042246 - main - Fix NULL deref segfault in bhyve's usb_mouse.c List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7631790422464de1aec309018e2c444defe5f629 Auto-Submitted: auto-generated Date: Fri, 09 Jan 2026 20:17:27 +0000 Message-Id: <69616257.8255.cd9e3ac@gitrepo.freebsd.org> The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=7631790422464de1aec309018e2c444defe5f629 commit 7631790422464de1aec309018e2c444defe5f629 Author: Jack Bendtsen AuthorDate: 2025-06-19 07:40:31 +0000 Commit: Warner Losh CommitDate: 2026-01-09 20:17:13 +0000 Fix NULL deref segfault in bhyve's usb_mouse.c Some of the cases inside umouse_request() (usr.sbin/bhyve/usb_mouse.c) use the data component of an event, while only partially checking if it's NULL. 'data' has a NULL check, but then 'data' is immediately deferenced anyway after the check regardless of if it's NULL or not. For example: case UREQ(UR_GET_STATUS, UT_READ_INTERFACE): case UREQ(UR_GET_STATUS, UT_READ_ENDPOINT): DPRINTF(("umouse: (UR_GET_STATUS, UT_READ_INTERFACE)")); if (data != NULL && len > 1) { USETW(udata, 0); data->blen = len - 2; data->bdone += 2; } eshort = data->blen > 0; break; There are actually four occurrences of this same bug, each in a different case in this switch block. Signed-off-by: Jack Bendtsen PR: 282237 Reviewed by: imp, jhb, vexeduxr MFC After: 1 week Pull Request: https://github.com/freebsd/freebsd-src/pull/1728 --- usr.sbin/bhyve/usb_mouse.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/usr.sbin/bhyve/usb_mouse.c b/usr.sbin/bhyve/usb_mouse.c index 82b1159d5f61..5caad886e082 100644 --- a/usr.sbin/bhyve/usb_mouse.c +++ b/usr.sbin/bhyve/usb_mouse.c @@ -538,7 +538,7 @@ umouse_request(void *scarg, struct usb_data_xfer *xfer) data->bdone += 2; } - eshort = data->blen > 0; + eshort = data != NULL && data->blen > 0; break; case UREQ(UR_GET_STATUS, UT_READ_INTERFACE): @@ -549,7 +549,7 @@ umouse_request(void *scarg, struct usb_data_xfer *xfer) data->blen = len - 2; data->bdone += 2; } - eshort = data->blen > 0; + eshort = data != NULL && data->blen > 0; break; case UREQ(UR_SET_ADDRESS, UT_WRITE_DEVICE): @@ -634,7 +634,7 @@ umouse_request(void *scarg, struct usb_data_xfer *xfer) data->blen = len - 1; data->bdone += 1; } - eshort = data->blen > 0; + eshort = data != NULL && data->blen > 0; break; case UREQ(UMOUSE_GET_PROTOCOL, UT_READ_CLASS_INTERFACE): @@ -643,7 +643,7 @@ umouse_request(void *scarg, struct usb_data_xfer *xfer) data->blen = len - 1; data->bdone += 1; } - eshort = data->blen > 0; + eshort = data != NULL && data->blen > 0; break; case UREQ(UMOUSE_SET_REPORT, UT_WRITE_CLASS_INTERFACE):