From owner-freebsd-ports@freebsd.org Sat Jul 4 05:11:28 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EB022361D8F for ; Sat, 4 Jul 2020 05:11:28 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49zKgN5LNbz4B0R; Sat, 4 Jul 2020 05:11:28 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from localhost (unknown [IPv6:2400:4051:a743:3c00:16:ceff:fe34:2700]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: hrs) by smtp.freebsd.org (Postfix) with ESMTPSA id A8E9528FE0; Sat, 4 Jul 2020 05:11:27 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Date: Sat, 04 Jul 2020 14:09:46 +0900 (JST) Message-Id: <20200704.140946.1661194655626577558.hrs@FreeBSD.org> To: 0mp@FreeBSD.org Cc: timp87@gmail.com, freebsd-ports@freebsd.org, manu@FreeBSD.org Subject: Re: set_rcvar() function use? From: Hiroki Sato In-Reply-To: <34921b6e-ce3a-13e4-0cc1-3ca47b5a9cef@FreeBSD.org> References: <20200703.035403.856368268140192104.hrs@FreeBSD.org> <34921b6e-ce3a-13e4-0cc1-3ca47b5a9cef@FreeBSD.org> X-Old-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-PGPkey-fingerprint: 6C0D 2353 27CF 80C7 901E FDD2 DBB0 7DC6 6F1F 737F X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha512; boundary="--Security_Multipart(Sat_Jul__4_14_09_46_2020_621)--" Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jul 2020 05:11:29 -0000 ----Security_Multipart(Sat_Jul__4_14_09_46_2020_621)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mateusz Piotrowski <0mp@FreeBSD.org> wrote in <34921b6e-ce3a-13e4-0cc1-3ca47b5a9cef@FreeBSD.org>: 0m> > I am planning to revisit the multi-instance support shortly because I 0m> > am using it for a long time and I think it is useful. While I did 0m> > not receive a strong objection to it so far, it is also true that 0m> > adopting the set_rcvar() style was not discussed properly. I would 0m> > like more feedback before moving forward. 0m> 0m> AFAIR, manu@ was concerned at some point that using set_rcvar() extensively 0m> might result in slowdowns on embedded systems. A discussion in the past about the performance was an additional fork(2) when using set_rcvar() for rc_var=`set_rcvar`. The use case of the resurrected one is "set_rcvar A B" as a replacement of "A=B", and it does not involve a subshell. I agree that the performance perspective should also be discussed, though. The current rc.subr and network.subr already have more expensive operations, so we might want to gather profiling information. -- Hiroki ----Security_Multipart(Sat_Jul__4_14_09_46_2020_621)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iMoEABMKAC4WIQRsDSNTJ8+Ax5Ae/dLbsH3Gbx9zfwUCXwAPGhAcaHJzQGZyZWVi c2Qub3JnAAoJENuwfcZvH3N/zxkCCQH66bdWDZ2aLTx4xHzTtw7T6wWNMtatuVoH qAngO26Vgpa+ZScyAmdcsSqEKVmXPhdd1B0VHL7yUJvj+oSY1vCMRgIJAX/LMSyn +7GFU9DayqcQ5O5M36pUnDTuEexePTrhJaozq0Pe82M2U7eY7CvGcuS5YTwEzDBF nTbxXHWh764R2+jO =e0Wo -----END PGP SIGNATURE----- ----Security_Multipart(Sat_Jul__4_14_09_46_2020_621)----