From owner-cvs-src@FreeBSD.ORG Mon Jan 10 20:23:48 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27A3B16A4CE; Mon, 10 Jan 2005 20:23:48 +0000 (GMT) Received: from zaphod.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6323C43D3F; Mon, 10 Jan 2005 20:23:47 +0000 (GMT) (envelope-from simon@zaphod.nitro.dk) Received: by zaphod.nitro.dk (Postfix, from userid 3000) id 9881011E13; Mon, 10 Jan 2005 21:23:45 +0100 (CET) Date: Mon, 10 Jan 2005 21:23:45 +0100 From: "Simon L. Nielsen" To: John-Mark Gurney Message-ID: <20050110202344.GC777@zaphod.nitro.dk> References: <200501061745.j06Hj344034786@repoman.freebsd.org> <20050110184139.GE19624@funkthat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rz+pwK2yUstbofK6" Content-Disposition: inline In-Reply-To: <20050110184139.GE19624@funkthat.com> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Maksim Yevmenkin cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netgraph ng_base.c src/sys/sys kernel.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jan 2005 20:23:48 -0000 --rz+pwK2yUstbofK6 Content-Type: multipart/mixed; boundary="LwW0XdcUbUexiWVK" Content-Disposition: inline --LwW0XdcUbUexiWVK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2005.01.10 10:41:39 -0800, John-Mark Gurney wrote: > Maksim Yevmenkin wrote this message on Thu, Jan 06, 2005 at 17:45 +0000: > > This does not address the bigger problem: MODULE_DEPEND > > does not seem to work when modules are compiled in the > > kernel, but it fixes the problem with Netgraph Bluetooth > > device drivers reported by a few folks. >=20 > The real problem is that MODULE_DEPEND only documents other kernel > dependancies, but does not reorder SYSINIT's... Considering that > SYSINIT's are always suppose to be ordered properly (otherwise, what > is the point of SYSINIT's) when staticly linked, having SYSINIT's not > properly ordered is the only bug... >=20 > If we move to a more complex and module aware system of SYSINIT's, then > it might happen, but this will be very difficult considering that when > staticly linked, you have no way to seperate which SYSINIT's belong to > which modules... >=20 > So, to everone, MODULE_DEPEND only marks which modules are required > for this module to work, it does not infulence startup ordering at > all... So, should I commit this patch? --=20 Simon L. Nielsen --LwW0XdcUbUexiWVK Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="man-MODULE_DEPEND-bugs.patch" Index: MODULE_DEPEND.9 =================================================================== RCS file: /home/ncvs/src/share/man/man9/MODULE_DEPEND.9,v retrieving revision 1.6 diff -u -d -r1.6 MODULE_DEPEND.9 --- MODULE_DEPEND.9 7 Jan 2005 08:44:31 -0000 1.6 +++ MODULE_DEPEND.9 10 Jan 2005 20:23:23 -0000 @@ -28,7 +28,7 @@ .\" .\" $FreeBSD: src/share/man/man9/MODULE_DEPEND.9,v 1.6 2005/01/07 08:44:31 keramida Exp $ .\" -.Dd January 7, 2005 +.Dd January 10, 2005 .Dt MODULE_DEPEND 9 .Os .Sh NAME @@ -69,3 +69,7 @@ .An -nosplit This manual page was written by .An Alexander Langer Aq alex@FreeBSD.org . +.Sh BUGS +.Nm +only marks which modules are required for the module to work, it does +not influence start-up ordering. --LwW0XdcUbUexiWVK-- --rz+pwK2yUstbofK6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFB4uRQh9pcDSc1mlERAjeCAJ9eR2GW+a+mgN7U+BiksyqE7qKqxQCgnUqy qVZKB3zyyMyPoxOI2nyzTAc= =vxBy -----END PGP SIGNATURE----- --rz+pwK2yUstbofK6--