Date: Sat, 11 May 2002 20:30:03 -0700 (PDT) From: Giorgos Keramidas <keramida@FreeBSD.org> To: freebsd-ports@FreeBSD.org Subject: Re: ports/37481: ZSNES 1.337 refuses to build against SDL 1.2.4 Message-ID: <200205120330.g4C3U3F01407@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/37481; it has been noted by GNATS. From: Giorgos Keramidas <keramida@FreeBSD.org> To: Dan Naumov <jago@telefragged.com> Cc: bug-followup@FreeBSD.org Subject: Re: ports/37481: ZSNES 1.337 refuses to build against SDL 1.2.4 Date: Sun, 12 May 2002 06:27:49 +0300 Adding to audit trail: .------- | Date: Tue, 7 May 2002 13:28:15 +0200 | From: Stijn Hoop <stijn@win.tue.nl> | Subject: pending/37822: Re: PR ports/37481: ZSNES 1.337 refuses to build against SDL 1.2.4 | | Hi Dan, | | On Fri, Apr 26, 2002 at 12:58:24PM +0300, Dan Naumov wrote: | > When trying to build the ZNES 1.337 emulator, which is in ports, it now | > attempts to build against the recently released SDL 1.2.4. The build fails | > with the following error: | | > linux/sdllink.o: In function `InitJoystickInput': | > linux/sdllink.o(.text+0xc1c): undefined reference to `SDL_NumJoysticks' | > linux/sdllink.o(.text+0xc4e): undefined reference to `SDL_JoystickEventState' | > linux/sdllink.o(.text+0xc6d): undefined reference to `SDL_JoystickOpen' | > linux/sdllink.o(.text+0xc7e): undefined reference to `SDL_JoystickName' | > linux/sdllink.o(.text+0xc8a): undefined reference to `SDL_JoystickNumButtons' | > gmake: *** [zsnes] Error 1 | > *** Error code 2 | > | > It used to build fine against SDL 1.2.3 and I also heard that 1.2.4 | > introduced some major changes to the Joystick code, so I am almost 100% | > positive that the problem is caused by the new SDL release. | | Well, it was *not* caused by the new SDL release, but by the fact that the | SDL maintainer disabled joystick support in the SDL port. | | > This report is posted to the GNATS database at: | > http://www.freebsd.org/cgi/query-pr.cgi?pr=37481 | > sorry that I originally forgot to 'cc you. | | Attached is a patch that disables the joystick code in zsnes; it seems to | work for me other than the obvious fact that it is now impossible to | use a joystick in zsnes. Could you let me know if it works for you too? | | I'm working with the SDL maintainer to see if we can fix the root of | the problem. | | If the patch also works for you, I'll bug a committer to add it to the | port for the time being. | | HTH, | | --Stijn | | --- linux/sdllink.c.orig Sun Sep 23 17:42:52 2001 | +++ linux/sdllink.c Tue May 7 13:16:21 2002 | @@ -536,6 +536,11 @@ | | for (i = 0; i < 5; i++) | JoystickInput[i] = NULL; | +#if 1 | + printf("ZSNES could not find any joysticks.\n"); | + SDL_QuitSubSystem(SDL_INIT_JOYSTICK); | + return FALSE; | +#else | // If it is possible to use SDL_NumJoysticks | // before initialising SDL_INIT_JOYSTICK then | // this call can be replaced with SDL_InitSubSystem | @@ -557,6 +562,7 @@ | } | | return TRUE; | +#endif | } | | BOOL InitInput() | @@ -572,7 +578,11 @@ | if (!sdl_inited) | { | if (SDL_Init(SDL_INIT_AUDIO | SDL_INIT_TIMER | | - SDL_INIT_VIDEO | SDL_INIT_JOYSTICK) < 0) | + SDL_INIT_VIDEO | +#if 0 | +| SDL_INIT_JOYSTICK | +#endif | + ) < 0) | { | fprintf(stderr, "Could not initialize SDL!\n"); | return FALSE; | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205120330.g4C3U3F01407>