From owner-freebsd-fs@freebsd.org  Tue Dec  4 07:35:12 2018
Return-Path: <owner-freebsd-fs@freebsd.org>
Delivered-To: freebsd-fs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4E3C132727D
 for <freebsd-fs@mailman.ysv.freebsd.org>; Tue,  4 Dec 2018 07:35:12 +0000 (UTC)
 (envelope-from mckusick@mckusick.com)
Received: from chez.mckusick.com (chez.mckusick.com [70.36.157.235])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B41F86AD59;
 Tue,  4 Dec 2018 07:35:11 +0000 (UTC)
 (envelope-from mckusick@mckusick.com)
Received: from chez.mckusick.com (localhost [IPv6:::1])
 by chez.mckusick.com (8.15.2/8.15.2) with ESMTP id wB47hf6Z092773;
 Mon, 3 Dec 2018 23:43:41 -0800 (PST)
 (envelope-from mckusick@mckusick.com)
Message-Id: <201812040743.wB47hf6Z092773@chez.mckusick.com>
From: Kirk McKusick <mckusick@mckusick.com>
To: Don Lewis <truckman@FreeBSD.org>
Subject: Re: stuck with ufs CHECK-HASH errors
cc: freebsd-fs@FreeBSD.org
X-URL: http://WWW.McKusick.COM/
Reply-To: Kirk McKusick <mckusick@mckusick.com>
In-reply-to: <tkrat.2f594d1b2546d371@FreeBSD.org>
Comments: In-reply-to Don Lewis <truckman@FreeBSD.org>
 message dated "Mon, 03 Dec 2018 23:08:50 -0800."
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <92771.1543909421.1@chez.mckusick.com>
Date: Mon, 03 Dec 2018 23:43:41 -0800
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,MISSING_MID,
 UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on chez.mckusick.com
X-Rspamd-Queue-Id: B41F86AD59
X-Spamd-Result: default: False [0.10 / 15.00]; ARC_NA(0.00)[];
 HAS_REPLYTO(0.00)[mckusick@mckusick.com];
 REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[];
 TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];
 NEURAL_HAM_LONG(-0.68)[-0.677,0]; MIME_GOOD(-0.10)[text/plain];
 DMARC_NA(0.00)[mckusick.com]; AUTH_NA(1.00)[];
 NEURAL_SPAM_SHORT(0.46)[0.459,0];
 IP_SCORE(-0.02)[country: US(-0.09)];
 MX_GOOD(-0.01)[cached: chez.mckusick.com];
 RCPT_COUNT_TWO(0.00)[2];
 RCVD_IN_DNSWL_NONE(0.00)[235.157.36.70.list.dnswl.org : 127.0.10.0];
 NEURAL_HAM_MEDIUM(-0.55)[-0.555,0]; R_SPF_NA(0.00)[];
 FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[];
 RCVD_TLS_LAST(0.00)[];
 ASN(0.00)[asn:46375, ipnet:70.36.128.0/19, country:US];
 RCVD_COUNT_TWO(0.00)[2]
X-Rspamd-Server: mx1.freebsd.org
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Dec 2018 07:35:12 -0000

> Date: Mon, 3 Dec 2018 23:08:50 -0800 (PST)
> From: Don Lewis <truckman@FreeBSD.org>
> Subject: Re: stuck with ufs CHECK-HASH errors
> To: Kirk McKusick <mckusick@mckusick.com>
> cc: freebsd-fs@FreeBSD.org
> 
> On  3 Dec, Kirk McKusick wrote:
> > I am working on a fix. Hopefully have it in no more than a day.
> 
> I figured out that ufs_disk_fillout() and therefore sbread() in libufs
> is never getting called.  Therefore the superblock used by cgput() is
> all zeros.  If I change the call to ufs_disk_fillout_blank() in setup()
> to ufs_disk_fillout() then things appear to work much better.

Yeah, that was my first attempt at a fix, but if the superblock has
a check-hash error, then fsck_ffs bails out at the ufs_disk_fillout()
call without getting down to the code that looks for alternate superblocks.
So, cannot use your fix long-term.

	Kirk McKusick