From owner-svn-src-all@freebsd.org Sun Sep 4 19:55:23 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4E3FB716A3 for ; Sun, 4 Sep 2016 19:55:23 +0000 (UTC) (envelope-from joerg@bec.de) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:c:538::195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 81F6384F for ; Sun, 4 Sep 2016 19:55:23 +0000 (UTC) (envelope-from joerg@bec.de) Received: from britannica.bec.de (p200300D2ABCFC4104639C4FFFE599710.dip0.t-ipconnect.de [IPv6:2003:d2:abcf:c410:4639:c4ff:fe59:9710]) (Authenticated sender: joerg@bec.de) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 224BBA80C0 for ; Sun, 4 Sep 2016 21:55:19 +0200 (CEST) Date: Sun, 4 Sep 2016 21:55:15 +0200 From: Joerg Sonnenberger To: svn-src-all@freebsd.org Subject: Re: svn commit: r305392 - head/sys/conf Message-ID: <20160904195515.GA1728@britannica.bec.de> References: <201609041755.u84HtMa5060050@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2 (2016-07-01) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Sep 2016 19:55:23 -0000 On Sun, Sep 04, 2016 at 09:31:19PM +0200, Dimitry Andric wrote: > On 04 Sep 2016, at 20:57, Conrad Meyer wrote: > > > > On Sun, Sep 4, 2016 at 10:55 AM, Dimitry Andric wrote: > >> Author: dim > >> Date: Sun Sep 4 17:55:22 2016 > >> New Revision: 305392 > >> URL: https://svnweb.freebsd.org/changeset/base/305392 > >> > >> Log: > >> For kernel builds, instead of suppressing certain clang warnings, make > >> them non-fatal, so there is some incentive to fix them eventually. > >> > >> Modified: > >> head/sys/conf/kern.mk > >> > >> Modified: head/sys/conf/kern.mk > >> ============================================================================== > >> --- head/sys/conf/kern.mk Sun Sep 4 17:50:23 2016 (r305391) > >> +++ head/sys/conf/kern.mk Sun Sep 4 17:55:22 2016 (r305392) > >> @@ -17,13 +17,13 @@ CWARNFLAGS?= -Wall -Wredundant-decls -Wn > >> # kernel where fixing them is more trouble than it is worth, or where there is > >> # a false positive. > >> .if ${COMPILER_TYPE} == "clang" > >> -NO_WCONSTANT_CONVERSION= -Wno-constant-conversion > >> -NO_WSHIFT_COUNT_NEGATIVE= -Wno-shift-count-negative > >> -NO_WSHIFT_COUNT_OVERFLOW= -Wno-shift-count-overflow > >> -NO_WSELF_ASSIGN= -Wno-self-assign > >> -NO_WUNNEEDED_INTERNAL_DECL= -Wno-unneeded-internal-declaration > >> +NO_WCONSTANT_CONVERSION= -Wno-error-constant-conversion > >> +NO_WSHIFT_COUNT_NEGATIVE= -Wno-error-shift-count-negative > >> +NO_WSHIFT_COUNT_OVERFLOW= -Wno-error-shift-count-overflow > >> +NO_WSELF_ASSIGN= -Wno-error-self-assign > >> +NO_WUNNEEDED_INTERNAL_DECL= -Wno-error-unneeded-internal-declaration > >> NO_WSOMETIMES_UNINITIALIZED= -Wno-error-sometimes-uninitialized > >> -NO_WCAST_QUAL= -Wno-cast-qual > >> +NO_WCAST_QUAL= -Wno-error-cast-qual > > > > I like goal of the change. Shouldn't these be -Wno-error=cast-qual, > > etc., though? > > That's how gcc spells them. Clang accepts both forms, there is no > functional difference. Actually, GCC documents them as -W(no-)error=* as well. Joerg