From owner-freebsd-current Wed Mar 26 07:38:29 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA16662 for current-outgoing; Wed, 26 Mar 1997 07:38:29 -0800 (PST) Received: from rover.village.org (rover.village.org [204.144.255.49]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id HAA16649 for ; Wed, 26 Mar 1997 07:38:26 -0800 (PST) Received: from rover.village.org [127.0.0.1] by rover.village.org with esmtp (Exim 1.60 #1) id 0w9um6-00055j-00; Wed, 26 Mar 1997 08:38:06 -0700 To: Bruce Evans Subject: Re: make world fails on libmytinfo Cc: current@freebsd.org, helbig@MX.BA-Stuttgart.De In-reply-to: Your message of "Wed, 26 Mar 1997 21:11:33 +1100." <199703261011.VAA05821@godzilla.zeta.org.au> References: <199703261011.VAA05821@godzilla.zeta.org.au> Date: Wed, 26 Mar 1997 08:38:05 -0700 From: Warner Losh Message-Id: Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk In message <199703261011.VAA05821@godzilla.zeta.org.au> Bruce Evans writes: : >Here is a patch fixing it. I consider clauses like "__FreeBSD != 2__" harmful. : >For those dependencies we have CVS, don't we. But there might be a reason : >for it, so I left them in. : : > /* for quit.c */ : > extern int sys_nerr; : >! #if __FreeBSD__ != 2 && __FreeBSD__ != 3 : > extern char *sys_errlist[]; : > #endif : > extern char *prg_name; : : It is just harmful. Const'ness of sys_errlist has nothing to do with : FreeBSD. : : BTW, sys_nerr is also const in FreeBSD, but the type mismatch is only : warned about if gcc is invoked with -pedantic. And it is even esier to fix. Most modern systems have errno.h. Just include that. Since it is in our CVS tree, that seems will be acceptible. Warner