From owner-cvs-all@FreeBSD.ORG Sun Aug 3 20:21:21 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 162D037B401; Sun, 3 Aug 2003 20:21:21 -0700 (PDT) Received: from shumai.marcuscom.com (rdu57-17-158.nc.rr.com [66.57.17.158]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEF4443F75; Sun, 3 Aug 2003 20:21:19 -0700 (PDT) (envelope-from marcus@marcuscom.com) Received: from shumai.marcuscom.com (localhost.marcuscom.com [127.0.0.1]) by shumai.marcuscom.com (8.12.9/8.12.9) with ESMTP id h743LHJj000585; Sun, 3 Aug 2003 23:21:17 -0400 (EDT) (envelope-from marcus@marcuscom.com) Received: from localhost (marcus@localhost)h743LHrM000582; Sun, 3 Aug 2003 23:21:17 -0400 (EDT) X-Authentication-Warning: shumai.marcuscom.com: marcus owned process doing -bs Date: Sun, 3 Aug 2003 23:21:17 -0400 (EDT) From: Joe Marcus Clarke To: Bosko Milekic In-Reply-To: <20030803230334.GA23042@technokratis.com> Message-ID: <20030803231836.T567@shumai.marcuscom.com> References: <200308040302.h7432aiM066088@repoman.freebsd.org> <20030803230334.GA23042@technokratis.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Bosko Milekic cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/lib match.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Aug 2003 03:21:21 -0000 On Sun, 3 Aug 2003, Bosko Milekic wrote: > > On Sun, Aug 03, 2003 at 08:02:36PM -0700, Bosko Milekic wrote: > > bmilekic 2003/08/03 20:02:36 PDT > > > > FreeBSD src repository > > > > Modified files: > > usr.sbin/pkg_install/lib match.c > > Log: > > Backout 1.14, it seems to be causing problems with libxml build > > and I don't have time to investigate this code in much detail right > > now. > > It's actually not the libxml build, but one that depends on both > libxml and libxml2. Actually, it affects a bunch of similar builds. Any port with has another port with a similar name (e.g. gnome vs. gnome2 ports, any portname with a portname-devel, etc.) will run into this problem. What happens is that the port to be checked passes its origin to the matchbyorigin() function, then that origin's strlen is passed to strncmp. Therefore, it only checks at most the number of characters in the original origin (missing the 2, -devel, -snap, etc.). Thanks for backing this out, Bosko. Joe > > > Revision Changes Path > > 1.15 +1 -1 src/usr.sbin/pkg_install/lib/match.c > > > > -- > Bosko Milekic * bmilekic@technokratis.com * bmilekic@FreeBSD.org > TECHNOkRATIS Consulting Services * http://www.technokratis.com/ > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > > PGP Key : http://www.marcuscom.com/pgp.asc