From owner-svn-src-all@freebsd.org Fri Apr 7 18:02:08 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84E67D3285E; Fri, 7 Apr 2017 18:02:08 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x235.google.com (mail-pg0-x235.google.com [IPv6:2607:f8b0:400e:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 535C3C93; Fri, 7 Apr 2017 18:02:08 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x235.google.com with SMTP id g2so72164204pge.3; Fri, 07 Apr 2017 11:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=g+JbnfKvDTATy35054sGbKY/3gAhfdflGffLceBO+1o=; b=Ig0PFawfePZbhjzeirj85ZIJgd1YqNbOnPEPVQOunGiTuam5nj5bnLsXb8ggevureF LPShWdoivL1C0BKvjLVNxEUT3dwqZbcsjrxx47flmMUit8VdqqQe3fN6gsSuVLtUCLde 4apjXVr5Vs/sGkt+Si4emzdBe5E+49IuK9fiZ7NErqjme8YnPOY6AlBZdtXxn171sWQU gYtDi5YCQVCBhYbqymH3rSJ5Y5ALqYw8FPRyB+n8SfGZPV1p1m1RECXqv95skqonLg7S 2990B2rpirFYGrrtuBHQAI3491mcaCf/r3oBXEUb1b7cGC6seSsjChgJctImuQqxHV7Z KSAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=g+JbnfKvDTATy35054sGbKY/3gAhfdflGffLceBO+1o=; b=gZqofwgCFwxLAyCkUv8wlgFdez8pOub2FMae8SfTeTcLm/ihQOTjxjz2MFUoIMUG7o cGRaecFtey2z5aT803PsfiaWJQdzw7F/qHGQkJeTkoOtYGsp9M5VNQ01yBNzMmKye2Q1 UlJmXrCrPRf22yub8HyRmKhCLqsBMyzNOdWxtZUN8iXj6glfWCt0KUGor14i0i57Yssi Ao6DUNF4Su0tZj9v9NSeKgTdpfBDyGGrIEosAGZ32qkGsX1kkOS+PeVwxlUX8QobIq05 oNGZOnfIpnjv6liYD+1n6Y8bVi6A/NhaOBMUtg75C5geQHSlzJEM9N42wVjDHUQgHCM2 yFIw== X-Gm-Message-State: AFeK/H0xDQHmypA5JcBVRQqrKZWJEuQUkEbj8s1Zdhf+guRaprlyW7OZ7WRtG0bjer4ozA== X-Received: by 10.84.239.8 with SMTP id w8mr51115790plk.73.1491588127959; Fri, 07 Apr 2017 11:02:07 -0700 (PDT) Received: from [192.168.20.13] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id w129sm10815525pfb.130.2017.04.07.11.02.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 11:02:07 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r316591 - head/sys/dev/tpm From: Ngie Cooper X-Mailer: iPhone Mail (14E277) In-Reply-To: <39DE48A2-9526-497E-B178-CE78B2EF4020@gmail.com> Date: Fri, 7 Apr 2017 11:02:06 -0700 Cc: "David E. O'Brien" , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <96F125AA-29BF-4CB5-9713-A398F650CBF2@gmail.com> References: <201704062221.v36MLnr7092648@repo.freebsd.org> <39DE48A2-9526-497E-B178-CE78B2EF4020@gmail.com> To: Xin LI X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 18:02:08 -0000 > On Apr 7, 2017, at 10:59, Ngie Cooper wrote: >=20 >=20 >> On Apr 7, 2017, at 10:17, Xin LI wrote: >>=20 >> No, David's change was correct. >>=20 >> The code context is something like: >>=20 >> #ifdef __FreeBSD__ >> [...] >> #else /* OpenBSD */ >> ... >> #ifdef __FreeBSD__ /* -- this portion got removed -- */ >> ... >> #else >> ... >> #endif >> [...] >> #endif >=20 > So, in short David enabled suspend/resume support in tpm(4)... (it looks l= ike it was disabled before, just based on the variable names/calls)? Why was= n't that clearly stated in the commit? Bah. I missed the nested FreeBSD in OpenBSD comment.. nevermind the part abo= ut enabling power support. It's too early for me to be thinking critically I= guess..=