From owner-freebsd-current@FreeBSD.ORG Mon Oct 31 21:10:30 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4359B16A43B for ; Mon, 31 Oct 2005 21:10:29 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id B892F43D9C for ; Mon, 31 Oct 2005 21:10:11 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [10.50.41.234] (Not Verified[10.50.41.234]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Mon, 31 Oct 2005 16:27:04 -0500 From: John Baldwin To: current@freebsd.org Date: Mon, 31 Oct 2005 17:11:49 -0500 User-Agent: KMail/1.8.2 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510311711.49927.jhb@freebsd.org> Cc: Subject: [PATCH] move exec_free_args() into do_execve() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Oct 2005 21:10:30 -0000 This patch removes some duplicate cleanup code from do_execve() failure cases and also moves the responsibility for exec_free_args() out of the callers of kern_execve() and into do_execve() instead: http://www.FreeBSD.org/~jhb/patches/exec_free_args.patch Please test, especially with various ABI binaries and with MAC policies enabled to make sure it doesn't break anything. Thanks! -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org