Date: Thu, 28 Jun 2001 19:35:35 -0400 From: Garance A Drosihn <drosih@rpi.edu> To: Mike Heffner <mheffner@vt.edu> Cc: freebsd-audit@FreeBSD.org Subject: RE: Initial ctlinfo, for checking incoming jobs to lpd Message-ID: <p05101000b76168e3258e@[128.113.24.47]> In-Reply-To: <XFMail.20010628184717.mheffner@novacoxmail.com> References: <XFMail.20010628184717.mheffner@novacoxmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks for checking thru it.
At 6:47 PM -0400 6/28/01, Mike Heffner wrote:
>| +
>| +struct cjobinfo *
>
>style(9) bug, extra spaces before asterick
Heh. Took me awhile to find this. In the original source it's
really a tab character, which only has to move over one spot so
it looked like a blank. In the diff-output, it is much more
obviously a tab. I have fixed it.
>| + while ((lbuff = ctl_getline(&(cpriv->pub)))) {
>
>should test against != NULL.
>
>| + else if (strcmp(cjinf->cji_orighost, ".na.") == NULL)
>| + nogood = 1;
>| + else if (strcmp(cjinf->cji_orighost, "localhost") == NULL)
>| + nogood = 1;
>
>strcmp() returns 0 for match
Oops, I thought I had fixed those. I have fixed them now.
>| +++ common_source/lp.h 2001/06/28 00:22:01
>| void prank(int _n);
>| void process(const struct printer *_pp, char *_file);
>| +void ctl_renametf(const char *_ptrname, const char *_tfname);
>
>This should line up.
Odd. In my source file, it DOES line up. It's even got the right
tab-space combination, so it isn't a mixup with tabs vs spaces. It
seems to line up OK in the message as I sent it, too. I don't know
what do say about this one.
--
Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu
Senior Systems Programmer or gad@freebsd.org
Rensselaer Polytechnic Institute or drosih@rpi.edu
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p05101000b76168e3258e>