From owner-freebsd-scsi Thu Jul 30 23:18:17 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA08723 for freebsd-scsi-outgoing; Thu, 30 Jul 1998 23:18:17 -0700 (PDT) (envelope-from owner-freebsd-scsi@FreeBSD.ORG) Received: from panzer.plutotech.com (panzer.plutotech.com [206.168.67.125]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA08717 for ; Thu, 30 Jul 1998 23:18:15 -0700 (PDT) (envelope-from ken@panzer.plutotech.com) Received: (from ken@localhost) by panzer.plutotech.com (8.8.8/8.8.5) id AAA15459; Fri, 31 Jul 1998 00:18:04 -0600 (MDT) From: "Kenneth D. Merry" Message-Id: <199807310618.AAA15459@panzer.plutotech.com> Subject: Re: camlib.h bugs In-Reply-To: from Cory Kempf at "Jul 31, 98 01:05:16 am" To: ckempf@enigami.com (Cory Kempf) Date: Fri, 31 Jul 1998 00:18:04 -0600 (MDT) Cc: freebsd-scsi@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL28s (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Cory Kempf wrote... > camlib.h is missing the lines > > __BEGIN_DECLS > __END_DECLS > > around the functions declared therein. Spot checks show that other .h > files are likewising missing these macros. > > Without these macros, the files won't link when called from C++. > > If you look in other include files (e.g. stdio.h), these macros are > present. It's an oversight. I'll add them in. > cam_open_device accepts flags for its second parameter. It would be > nice if camlib.h included fcntl.h where these flags are defined. scsi_open() in the old SCSI userland code takes the same kind of flags, and doesn't include fcntl.h. (although that in and of itself isn't a reason not to do it) I suppose it's assumed that if you want the O_RDONLY or O_RDWR flags, you'll need to include the file that defines them. Ken -- Kenneth Merry ken@plutotech.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message