From nobody Thu Aug 7 18:26:54 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bybGk46z4z64Znr; Thu, 07 Aug 2025 18:26:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bybGk2Gmfz3nXW; Thu, 07 Aug 2025 18:26:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754591214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nzPGw5h+XUxbazG0gyKL/z1+1soYABem1YiAqNjLk7w=; b=Lvc0fzAwnFJb03gWPWQx2w9k4SJbcngTSQGc/dEth5wz0NOmb4dLtiA4SpezSuSA9vyuQw ZGfBVbQQ/aPo7jQGESiql45Ma10Q9HroMayQ+s28Nw3m9kcvCGtkNlY8x6dbbKw1iD0YcM jDvDDAe27xZW5LLz1koo0uyJua4/StVL/DFPXPLMHBuhgPpNPCm9LTVgjk/8tM9VT0KlIG 03vogqc0mJMBpml1g8ofM/XJe/uujccTLMG2F+tjkN5FpYwOqvmg5buVX0BzjmridVeGyk a9etY2aIYElHIC4DJw9fENVwh07v3Ny18E7i0ipKsPw1Y45rmJMPxT0/8VAinw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754591214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nzPGw5h+XUxbazG0gyKL/z1+1soYABem1YiAqNjLk7w=; b=R/tbTM31/hVKM5ilg6leCPJaQr2FeLstWK4g+fm72+mBpWRIrJxyuPj4aSZVfVs++E+dCp eKi4nic+DCrsfU6TdXPXDWxfyVNToowE4E9+s0gvMRK6e9AUhkomAk60HGwAZpm8OMPz5M DSFNPgeODJBRwMnRtyuqZP+9mqbXtEWDk3gJCe5MF5/uldKAHH9fw2MLBAAv0SzZbls9Yx kqSIY6DOiiHroRIg8MxpdQbzPoj0w/EVkYqhX7PIus3rXZWSqLFVGTo096eM8JGnzX6Yxo 8s8odY7KXBFrf+ebSxQyy7KTiZgtJmEgVOj+pFRYg8rV17RvV31LUjUfWcQMWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754591214; a=rsa-sha256; cv=none; b=t7Y8uQiCv5phDLLMGRjj//rc+sp9P+ck3b6sUgJjZGL6ND6xoGED6LHQtASaGx731Kdbmy ng3PXupVHC+n+afsNC//AS+wkYYyK2Qr9LRwOSNMilCX0//6uJ61mMcV8K1hNPQ68RG6LA Libf2/d5MSLXMcFQLwEtZOyqvoaO3TIPLDtro15Oj2BkLZvXyFS2Sy05Mj7OBBBjAyX6XH PrurdQsNn9yMVr7G/8KE7k7cr9B9zedCl8hB8vLq+N2Q2YC/ef1dWQ9hB1lJHy8/36YL0t 7HXIF9SLRkxEPTOIcEpM0RVLYaScfcZMtXDPbniN9O21/yyqt+HXMB+kkKBCkQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bybGk1Xx6z1GtT; Thu, 07 Aug 2025 18:26:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 577IQsfo081563; Thu, 7 Aug 2025 18:26:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 577IQsIO081560; Thu, 7 Aug 2025 18:26:54 GMT (envelope-from git) Date: Thu, 7 Aug 2025 18:26:54 GMT Message-Id: <202508071826.577IQsIO081560@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 3c4b3bab19ca - main - chroot: Remove always-true checks List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3c4b3bab19ca66bbb3c53275c51d4bf863059fb2 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=3c4b3bab19ca66bbb3c53275c51d4bf863059fb2 commit 3c4b3bab19ca66bbb3c53275c51d4bf863059fb2 Author: John Baldwin AuthorDate: 2025-08-07 17:48:36 +0000 Commit: John Baldwin CommitDate: 2025-08-07 18:26:46 +0000 chroot: Remove always-true checks gid_t and uid_t are unsigned types, so the values are always >= 0. usr.sbin/chroot/chroot.c: In function 'resolve_group': usr.sbin/chroot/chroot.c:68:55: error: comparison of unsigned expression in '>= 0' is always true [-Werror=type-limits] 68 | if (errno == 0 && *endp == '\0' && (gid_t)gid >= 0 && gid <= GID_MAX) | ^~ usr.sbin/chroot/chroot.c: In function 'resolve_user': usr.sbin/chroot/chroot.c:87:55: error: comparison of unsigned expression in '>= 0' is always true [-Werror=type-limits] 87 | if (errno == 0 && *endp == '\0' && (uid_t)uid >= 0 && uid <= UID_MAX) | ^~ Reported by: GCC Fixes: 91eb4d2ba4de ("chroot: slightly cleanup") --- usr.sbin/chroot/chroot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/chroot/chroot.c b/usr.sbin/chroot/chroot.c index 8a99a9bbf7cb..d9fb29474d87 100644 --- a/usr.sbin/chroot/chroot.c +++ b/usr.sbin/chroot/chroot.c @@ -65,7 +65,7 @@ resolve_group(const char *group) */ errno = 0; gid = strtoul(group, &endp, 0); - if (errno == 0 && *endp == '\0' && (gid_t)gid >= 0 && gid <= GID_MAX) + if (errno == 0 && *endp == '\0' && gid <= GID_MAX) return (gid); errx(1, "no such group '%s'", group); @@ -84,7 +84,7 @@ resolve_user(const char *user) errno = 0; uid = strtoul(user, &endp, 0); - if (errno == 0 && *endp == '\0' && (uid_t)uid >= 0 && uid <= UID_MAX) + if (errno == 0 && *endp == '\0' && uid <= UID_MAX) return (uid); errx(1, "no such user '%s'", user);