Date: Thu, 24 Dec 2015 10:52:06 -0700 From: Adam Weinberger <adamw@adamw.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r404326 - head/shells/zsh Message-ID: <1A952F45-D4C6-4039-9FEA-749F0CC58DE8@adamw.org> In-Reply-To: <20151223231402.GF20454@ivaldir.etoilebsd.net> References: <201512232256.tBNMukWr007966@repo.freebsd.org> <20151223231402.GF20454@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 23 Dec, 2015, at 16:14, Baptiste Daroussin <bapt@FreeBSD.org> = wrote: >=20 > On Wed, Dec 23, 2015 at 10:56:46PM +0000, Adam Weinberger wrote: >> Author: adamw >> Date: Wed Dec 23 22:56:46 2015 >> New Revision: 404326 >> URL: https://svnweb.freebsd.org/changeset/ports/404326 >>=20 >> Log: >> Partially revert r403755. It can't build the curses module against = ncurses from >> ports. It probably can, but configure is too smart to figure that = out. >>=20 >> I have no confidence that linking against curses from ports results = in a properly >> working zshell. So, for now, back out the change. It will build a = shared lib zsh >> against ncurses from ports, but breaks statically-linked zsh's. Mark = the port >> as IGNORE if we're using ncurses from ports and building a static = zsh. >>=20 >> Also, remove a regression-test target that isn't useful anymore = (thanks to bapt >> for the reminder about this). >>=20 >> I am not enthused about this change. It doesn't really "fix" the = below PR, so >> much as shoot ourselves in the other foot instead. >>=20 >> PR: 205500 >>=20 > The solution is to make --with-term-lib=3D"tinfow tinfo" only when = building static > because when building static you will never build the curses module >=20 > something like --with-term-lib=3D"${TERMLIB}" > TERMLIB=3D"ncursesw ncurses" >=20 > then later: > .if ${PORT_OPTIONS:MSTATIC} > TERMLIB=3D"tinfow tinfo" > .endif >=20 > Which will also fix static building with base the day we split = libtinfo* from > libncurses, which would be nice to do in base :) bapt, you are my hero. Thank you! Committed in r404382. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1A952F45-D4C6-4039-9FEA-749F0CC58DE8>