From owner-cvs-all Sun Nov 14 4:23:11 1999 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id B9EA114E91; Sun, 14 Nov 1999 04:23:01 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from p70-ts5.syd2.zeta.org.au (beefcake.zeta.org.au [203.26.10.12]) by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id XAA04480; Sun, 14 Nov 1999 23:28:49 +1100 Date: Sun, 14 Nov 1999 23:22:16 +1100 (EST) From: Bruce Evans X-Sender: bde@alphplex.bde.org To: Marcel Moolenaar Cc: Martin Cracauer , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include signal.h In-Reply-To: <382E8A1B.B7D9B7F0@scc.nl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Sun, 14 Nov 1999, Marcel Moolenaar wrote: > Martin Cracauer wrote: > > > Reserve space for FPU state in struct sigcontext. Fix some style bugs > > > and comments while there. > > > > I still don't like this approach of unstructred allocated space, an > > array of unnamed bytes. > > It's what it says it is: it's a space reservation. If someone actually > implements saving the FPU state, then he/she is free (IMO) to change the > reservation into whatever he/she things he/she needs or thinks is > meaningful. Martin implemented saving it before you complicated things by changing the signal handling :-). I didn't like it because it moved the definitions of i386 FP structs to the wrong place (). It's not clear that there is a right place. > The reason for the space reservation is to work towards an unified > context. mcontext_t also has the space reservation... We seem to have missed allocating some necessary space. glibc-2.1.1 has: int sc_fpkind; /* FP_NO, FP_387, etc. */ int sc_fpused; /* If zero, ignore rest of float state. */ int at least some declarations of struct sigcontext. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message