Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Dec 2019 14:21:40 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r355287 - head/sys/dev/mlx5/mlx5_core
Message-ID:  <201912021421.xB2ELeaF043347@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Mon Dec  2 14:21:40 2019
New Revision: 355287
URL: https://svnweb.freebsd.org/changeset/base/355287

Log:
  mlx5: Downgrade assert about misbehaving hardware to error message.
  
  Sponsored by:	Mellanox Technologies
  MFC after:	1 week

Modified:
  head/sys/dev/mlx5/mlx5_core/mlx5_fwdump.c

Modified: head/sys/dev/mlx5/mlx5_core/mlx5_fwdump.c
==============================================================================
--- head/sys/dev/mlx5/mlx5_core/mlx5_fwdump.c	Mon Dec  2 12:26:47 2019	(r355286)
+++ head/sys/dev/mlx5/mlx5_core/mlx5_fwdump.c	Mon Dec  2 14:21:40 2019	(r355287)
@@ -137,9 +137,11 @@ mlx5_fwdump_prep(struct mlx5_core_dev *mdev)
 			mdev->dump_rege[++i].addr = next_addr;
 		addr = next_addr;
 	}
-	KASSERT(i + 1 == sz,
-	    ("inconsistent hw crspace reads: sz %u i %u addr %#lx",
-	    sz, i, (unsigned long)addr));
+	if (i + 1 != sz) {
+		mlx5_core_err(mdev,
+		    "Inconsistent hw crspace reads: sz %u i %u addr %#lx",
+		    sz, i, (unsigned long)addr);
+	}
 
 	mdev->dump_size = mlx5_fwdump_getsize(mdev->dump_rege);
 	mdev->dump_data = malloc(mdev->dump_size * sizeof(uint32_t),



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201912021421.xB2ELeaF043347>