Date: Thu, 9 Feb 2012 12:48:26 -0800 From: Dmitry Mikulin <dmitrym@juniper.net> To: Konstantin Belousov <kostikbel@gmail.com> Cc: freebsd-current Current <freebsd-current@freebsd.org>, Marcel Moolenaar <marcelm@juniper.net> Subject: Re: [ptrace] please review follow fork/exec changes Message-ID: <4F34311A.9050702@juniper.net> In-Reply-To: <20120209122908.GD3283@deviant.kiev.zoral.com.ua> References: <20120129074843.GL2726@deviant.kiev.zoral.com.ua> <4F26E0D1.8040100@juniper.net> <20120130192727.GZ2726@deviant.kiev.zoral.com.ua> <4F2C756A.80900@juniper.net> <20120204204218.GC3283@deviant.kiev.zoral.com.ua> <4F3043E2.6090607@juniper.net> <20120207121022.GC3283@deviant.kiev.zoral.com.ua> <4F318D74.9030506@juniper.net> <4F31C89C.7010705@juniper.net> <4F3318AD.6000607@juniper.net> <20120209122908.GD3283@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
> The semantic of PL_FLAG_EXEC up until now is very simple: it indicates > that current stop occured during the first return to usermode after > successful exec. The proposed patch breaks the semantic, because now > some stops which satisfy the stated condition are no longer marked with > the flag. > > That said, I am lost. You stated that you still need some stops at > exec even when not PT_FOLLOW_EXEC is requested. Why usermode cannot > remember whether the PT_FOLLOW_EXEC was set for the process, and ignore > PL_FLAG_EXEC if not requested ? I was trying to avoid making ugly changes in gdb if it was possible not to make ugly changes in the kernel. I changed gdb to work without PT_FOLLOW_EXEC. > I just gave up and added PL_FLAG_EXECF, which is set when PT_FOLLOW_EXEC > was set and exec is active. Would this work for your purposes ? > PL_FLAG_EXECF has the same semantic as PL_FLAG_EXEC had in your > follow-exec.patch. But the stop set is not changed comparing with the > stock src. > > Are you fine with PL_FLAG_CHILD part of the changes ? If yes, I will > commit it to make some progress. yes, the PL_FLAG_CHILD part works for me. Please commit it and we can move on to the next part of the review.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F34311A.9050702>