Date: Wed, 26 Jan 2022 13:31:40 +0100 From: Emmanuel Vadot <manu@bidouilliste.com> To: Michael Reifenberger <mr@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 19eaa01beaba - main - Append Keyboard Layout specified option for using VNC. Part two: Append bhyve -K option for specified keyboard layout with layout setting files every languages. Since the cmd option '-k' was used in the meantime it was changed to '-K' Message-ID: <20220126133140.3255cae69c0c0d16976dd6aa@bidouilliste.com> In-Reply-To: <202201202250.20KMoHiA013578@gitrepo.freebsd.org> References: <202201202250.20KMoHiA013578@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello Michael, On Thu, 20 Jan 2022 22:50:17 GMT Michael Reifenberger <mr@FreeBSD.org> wrote: > The branch main has been updated by mr: > > URL: https://cgit.FreeBSD.org/src/commit/?id=19eaa01beaba68ed4c70c44127955f5c9b331cb9 > > commit 19eaa01beaba68ed4c70c44127955f5c9b331cb9 > Author: Michael Reifenberger <mr@FreeBSD.org> > AuthorDate: 2022-01-20 22:44:04 +0000 > Commit: Michael Reifenberger <mr@FreeBSD.org> > CommitDate: 2022-01-20 22:49:27 +0000 > > Append Keyboard Layout specified option for using VNC. > Part two: Append bhyve -K option for specified keyboard layout > with layout setting files every languages. > Since the cmd option '-k' was used in the meantime > it was changed to '-K' > > PR: 246121 > Submitted by: koinec@yahoo.co.jp > Reviewed by: grehan@ It doesn't appears to have been accepted. > Differential Revision: https://reviews.freebsd.org/D29473 > > MFC after: 4 weeks The files aren't taggued correctly for pkgbase but I'll fix that in a bit. May I ask why this format was chosen ? How was it generated ? I'm not sure what do they contain too, is the first column the keycode and the other the ascii code ? If yes then there is at least a problem in the fr layout where the keycode for 'A'/'a' is 0x15 while in reality it's 0x14. Also the fr file have a comment that says "fr : French French Canadian (accent keys) Swiss-French", what does this means ? All three have different keyboard layout so I don't see how this should work. We also already have two (at least) keymap files installed, one for syscon and one for vt, re-using them (or modifying vt/sc and bhyve to use one keymap file) would really be better. Cheers, -- Emmanuel Vadot <manu@bidouilliste.com> <manu@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220126133140.3255cae69c0c0d16976dd6aa>