From owner-svn-src-all@freebsd.org Sat Sep 28 16:35:11 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5211F12B036 for ; Sat, 28 Sep 2019 16:35:11 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46gZ5V6X1Gz4NVB for ; Sat, 28 Sep 2019 16:35:10 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1569688509; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=twfqhwrPIJ8EBg5i2iQ+PYctIYpaGQeRcYIod+CMKo0Pny38l5xAeXIYxnGWBTpvsz0onQ54h302Q cbiBPPESFlOOV/Yqsrna1j12Ihc1oNQo2jKH78SnZvC5Tkyx1xevwCjnwd0doTiP6sLVd3o01Cwwec XdvymXfT/Aio6Ou0DlFoBPBh2S2xdYleJQJleskXWTiTUJbO6KVGurSpiOWxnLeOC01urRYdGAy/qj vuB9fdYM/EL37gc18RGkicn7Ey9FstksmONB528orKHiMc8J1PbH1xOTH3YVNitrCX9goujdPiEmUu UDnkFdLsHQHMJ12/O+IPXujXmUqSSzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=InRP89POJRp6SJoWzlA2+RR5feZNPRuHTqwKZ9OMqv8=; b=Uho81i/e2VIsGzZNQKpoS1Yg7yOmbCaK5JrUuvBbosFMp61NmAKUJdvDAGU2fGooBZXUeKz5CPaWi XMhiZLRKAaV4fl/3pHo3twebkpsSGLK3IJPP8bx8pWOFNeu0SBmbQmYgwIXGPMtgpjU91/zIO85VHL 1wqfPvYNtf1rwYzcGqVWHZmpEFsvLakT20szpxR219g6KYOfd1WdWA1ugGf2hNCKdknzzyLR1KhAKs Q56lwfmvnsGnTV3etVuEvJVZ7opMY+XUk6LMEgyMwmhWNadNNkiP4fT7PE6VB7GBB5Cj3C1jb1l04q qNt4ZD1nb/yxGH1pV9TzDRYREF4qLlg== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=InRP89POJRp6SJoWzlA2+RR5feZNPRuHTqwKZ9OMqv8=; b=KVdyUS2QDmhI4hxr1cT8HuiGlQIT2dNtMijjq30GVtU5ZNKSRE4CGJNqlnZOKWMYvlB+TWJSsyM7f UmNpX9q0pQOOcbmmL8djqo7EI8/pvSR0NnVYFU2QjkBkkaaAUvgmLUiMo3o9frDDlrUn6KtjxN5TLE 7oqdQVzrTGbIaUEqhu6suUjmr0Zo9p2MnFy0BdW8ss5vDiC/4uoDPVrctkAS/TpxXlm5qEhlO3TE6y 2lHtpwmA4AzfDwTUMr/SEEcKT56mRAtEPWhTDIokv0WqhCLSqm/NRPWvWvFOCtJqXzwikD6XwSyhCV oYMgD3hHSVNGjJU73LEE8ilfS8H9IyA== X-MHO-RoutePath: aGlwcGll X-MHO-User: ee080cd8-e20d-11e9-85ed-13b9aae3a1d2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id ee080cd8-e20d-11e9-85ed-13b9aae3a1d2; Sat, 28 Sep 2019 16:35:07 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x8SGZ6VI044669; Sat, 28 Sep 2019 10:35:06 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r352838 - head/share/man/man3 From: Ian Lepore To: Edward Tomasz Napierala , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sat, 28 Sep 2019 10:35:06 -0600 In-Reply-To: <201909280937.x8S9b5R7060791@repo.freebsd.org> References: <201909280937.x8S9b5R7060791@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46gZ5V6X1Gz4NVB X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.98)[-0.979,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:16509, ipnet:54.148.0.0/15, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Sep 2019 16:35:11 -0000 On Sat, 2019-09-28 at 09:37 +0000, Edward Tomasz Napierala wrote: > Author: trasz > Date: Sat Sep 28 09:37:05 2019 > New Revision: 352838 > URL: https://svnweb.freebsd.org/changeset/base/352838 > > Log: > Sort MLINKS for arb(3), and actually make them work by fixing a '=' > vs '+=' > mixup. > ::sigh:: This wouldn't happen if we just always used += for all lines in lists of things, but sadly (IMO, surrealistically), style.Makefile explicitly prohibits that. I'm not sure what value the prohibition is supposed to provide, but the downsides are making this mistake over and over again, and if you manage to avoid the mistake your consolation prize is a diff that's less-clear because you have to change lines that aren't actually involed in the change you're making. -- Ian