From nobody Fri Oct 10 17:16:19 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cjtgl4pbYz6Bcgj; Fri, 10 Oct 2025 17:16:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cjtgl3GNpz3gQ3; Fri, 10 Oct 2025 17:16:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760116579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V6XWB113U5+Nio5n9iTqQ38TfPX2wE2a2g3yRUqCqM4=; b=S3eY2Dkzf+EjtIVbOZF4SqfFfyAN9PE9Sxo94b2u5y/8O1QreO9HkEzmrgdWUP20NN2EzF pIV97nAylhW/JlujxlCEIBHRo78kPZ8z5Gr7LzHNz8B1Ht4XOu24VAH3IdtQChYITk7AgZ x4fF2w0AGldvqI5/6vZJa3quZmLG/HwilB4UlziUpH01Jprkd3bd6LDb+EciQP0k7d8WUG HvawlGoAyjPLCPGIj/F81XgFCAOx2oe93mcW5E2lVE5s1eBe4UATYs4vsiQBw5ZNcgCHUC LAlct48oysjFgn+jBAXUsWno2PPLmhn2YwyDe0qkaQTEhfZKbSoQxKt6BojJwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760116579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V6XWB113U5+Nio5n9iTqQ38TfPX2wE2a2g3yRUqCqM4=; b=FUt7vGvTPEAc249ski84oFgD3HjjZNlY4qbJd+8cHlGZcRYK9IRm9kXBI560IjrwSErW9Z 1m3v6zZuuE9iOjumK7ZQbCtpPXxu1U+0rZ+vmP5uXQy2oSj1LWGK3ClXDNjDzUXuOXmPUL ANhiXKo8v7U0mCIHMOj0rX6sYpnkvORA1laBVAjVfsVNopUJ/UG5X01mFmvVFXjLUg7GCA w0mMiiQ3G6Jjh8h5rqxFFi/Ynvm/tGGcZyX4JEDRaR/7i4oakTMqxjItSICjZ/JSc3TUTL pXUxDxbhuTfBOj0ptk6CedSIqhsEgyMFg8SVIVPeaFmhtGx2rz9hXjTnrnwSBA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760116579; a=rsa-sha256; cv=none; b=KQ+LwWvVnqjhT/x9XZLwSOkolg2sPBDrinTcX3upiPzbEoPzaQttm7d5g05voRSHlFEKIR ZbnAgJkYSVLg/9joSnn4YoEP98s2H0HcLzeWaZnddnbH8YPqjj3h0CpcEdDjxavzoX4CtU 8osOjCiUkl+bH7vDcq1Vrenj1nYp0Fo6XatALTBJq+LijeTvhFN5Xf29Lzy6zPIDnlQYIJ JDL+TBge/RnCZew5lh1MDw/vvYSAzywK/XOJykwfNzL9tn+gWr3b2CVxk15uzqNKSLVHyz SrZiJ4dku4gRZG/ImuIZ0M1Q9LJZINLMpTPvl2JSEEMv0GbXdBGgHXGYeWEL0Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cjtgl2npBz1Br4; Fri, 10 Oct 2025 17:16:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59AHGJ5R009179; Fri, 10 Oct 2025 17:16:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59AHGJCu009176; Fri, 10 Oct 2025 17:16:19 GMT (envelope-from git) Date: Fri, 10 Oct 2025 17:16:19 GMT Message-Id: <202510101716.59AHGJCu009176@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 216460b80674 - stable/14 - linux: setgroups(): Avoid allocation under the process lock List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 216460b806742c8c0a97aec2c9a689a17c564beb Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=216460b806742c8c0a97aec2c9a689a17c564beb commit 216460b806742c8c0a97aec2c9a689a17c564beb Author: Olivier Certner AuthorDate: 2025-08-28 15:47:38 +0000 Commit: Olivier Certner CommitDate: 2025-10-10 17:15:56 +0000 linux: setgroups(): Avoid allocation under the process lock This was missed in commit 838d9858251e ("Rework the credential code to support larger values of NGROUPS (...)"). No functional change (intended). MFC after: 5 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52278 (cherry picked from commit b7a87d7c0dd19016e82f5d33f2c5ec90479c31fe) --- sys/compat/linux/linux_misc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/compat/linux/linux_misc.c b/sys/compat/linux/linux_misc.c index 855c1d885164..2ae10a487813 100644 --- a/sys/compat/linux/linux_misc.c +++ b/sys/compat/linux/linux_misc.c @@ -1044,8 +1044,7 @@ linux_setgroups(struct thread *td, struct linux_setgroups_args *args) crextend(newcred, ngrp + 1); p = td->td_proc; PROC_LOCK(p); - oldcred = p->p_ucred; - crcopy(newcred, oldcred); + oldcred = crcopysafe(p, newcred); /* * cr_groups[0] holds egid. Setting the whole set from