From owner-svn-src-head@FreeBSD.ORG Mon Dec 12 16:33:08 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0644B106568C; Mon, 12 Dec 2011 16:33:08 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 31B588FC32; Mon, 12 Dec 2011 16:33:07 +0000 (UTC) Received: by faaf16 with SMTP id f16so464195faa.13 for ; Mon, 12 Dec 2011 08:33:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=s/tdSP7RIRhv0qqMRTH15KnyR9IvV2CxKuIkjhZG11Y=; b=kEyyGYLPMF/HnSV1ROJIBWdjLYUWWTyZpbKbckKr4SHwusUfUl6Asr2VZ0Ha9ekkXb TcJJ6szMTPi0wRpubeRU1wg3LAZqX8fcWiCnOshY5VX+e28xn+Qc4RFKj+X56NLswsJs qPQv1dJaF85jOJlZgSFmUeUor/50qeNkEC9IU= MIME-Version: 1.0 Received: by 10.180.96.103 with SMTP id dr7mr23323388wib.16.1323706227418; Mon, 12 Dec 2011 08:10:27 -0800 (PST) Sender: asmrookie@gmail.com Received: by 10.216.171.8 with HTTP; Mon, 12 Dec 2011 08:10:27 -0800 (PST) In-Reply-To: <4EE5D574.9080303@FreeBSD.org> References: <201112121005.pBCA5Dar093711@svn.freebsd.org> <20111212101558.GK50300@deviant.kiev.zoral.com.ua> <4EE5D574.9080303@FreeBSD.org> Date: Mon, 12 Dec 2011 17:10:27 +0100 X-Google-Sender-Auth: CF3_-ni9bWSySsipDzOFWE3mEpM Message-ID: From: Attilio Rao To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Kostik Belousov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228433 - in head/sys: kern security/mac X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Dec 2011 16:33:08 -0000 2011/12/12 Andriy Gapon : > on 12/12/2011 12:15 Kostik Belousov said the following: >> On Mon, Dec 12, 2011 at 10:05:13AM +0000, Andriy Gapon wrote: >>> Author: avg >>> Date: Mon Dec 12 10:05:13 2011 >>> New Revision: 228433 >>> URL: http://svn.freebsd.org/changeset/base/228433 >>> >>> Log: >>> =C2=A0 put sys/systm.h at its proper place or add it if missing >>> >>> =C2=A0 Reported by: =C2=A0 =C2=A0 =C2=A0 lstewart, tinderbox >>> =C2=A0 Pointyhat to: =C2=A0 =C2=A0 =C2=A0avg, attilio >>> =C2=A0 MFC after: 1 week >>> =C2=A0 MFC with: =C2=A0r228430 >>> >>> Modified: >>> =C2=A0 head/sys/kern/kern_sx.c >>> =C2=A0 head/sys/kern/vfs_cache.c >>> =C2=A0 head/sys/security/mac/mac_framework.c >>> =C2=A0 head/sys/security/mac/mac_priv.c >> It means that previously sx.h did not required systm.h and now it does ? >> Might be, you should move SCHEDULER_STOPPED and stop_scheduler declarati= ons >> into sys/lock.h ? >> > > Strictly speaking it's sys/lockstat.h that now requires systm.h. > I am not an expert in FreeBSD header file organization, so I will just fo= llow > whatever the experts advise. I think that we should revert this part of the patch and just fix dtrace_probe() for pollution, this way we get the same effect and avoid namespace pollution (and still improve the MFC situation). I'll make a patch available in the next hour. Attilio --=20 Peace can only be achieved by understanding - A. Einstein