From owner-freebsd-audit Sun Jun 3 17:58: 1 2001 Delivered-To: freebsd-audit@freebsd.org Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19]) by hub.freebsd.org (Postfix) with ESMTP id 241D537B403 for ; Sun, 3 Jun 2001 17:57:59 -0700 (PDT) (envelope-from mike@q9media.com) Received: from [192.168.1.10] (vega.tct.net [216.94.230.13]) by coffee.q9media.com (8.11.2/8.11.2) with ESMTP id f5417JL94692; Sun, 3 Jun 2001 21:07:19 -0400 (EDT) (envelope-from mike@q9media.com) User-Agent: Microsoft-Outlook-Express-Macintosh-Edition/5.02.2022 Date: Sun, 03 Jun 2001 20:57:55 -0400 Subject: Re: whois(1) patch From: Mike Barcroft To: Garance A Drosihn Cc: , Mike Heffner Message-ID: In-Reply-To: Mime-version: 1.0 Organization: q9 media Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 6/3/01 1:50 AM, Garance A Drosihn at drosih@rpi.edu wrote: > At 6:26 PM -0400 5/31/01, Mike Heffner wrote: >> On 31-May-2001 Mike Barcroft wrote: >> | >> | I originally made the ANSI C change to silence a warning, but is >> | there any reason not to bring the code up to ANSI C spec? Is it >> | likely that anyone will need to compile whois with a K&R compiler? >> >> It's not likely, but I'm not sure on what the consensus is on >> ANSI-fication. Technically, style(9) says it shouldn't be done in >> this case, but people (myself included) have been removing K&R >> support in small patches like this one. I think there was also talk >> of doing a full sweep to remove __P. > > It is not likely that there will be a specific sweep to get rid > of _P() and to ansi-ify routine declarations. However, the > consensus is that if you are going to be changing the declarations > in some module for OTHER reasons, then you might want to ansi-ify. > > If you're going to ansi-ify, then you should ansi-ify the whole > source file, instead of mixing styles. Agreed. Are there any ANSI-ifications I missed in my patch? Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message