From owner-freebsd-alpha Wed Aug 22 12:55: 9 2001 Delivered-To: freebsd-alpha@freebsd.org Received: from earth.backplane.com (earth-nat-cw.backplane.com [208.161.114.67]) by hub.freebsd.org (Postfix) with ESMTP id 322FC37B43F; Wed, 22 Aug 2001 12:54:41 -0700 (PDT) (envelope-from dillon@earth.backplane.com) Received: (from dillon@localhost) by earth.backplane.com (8.11.4/8.11.2) id f7MJsbd77448; Wed, 22 Aug 2001 12:54:37 -0700 (PDT) (envelope-from dillon) Date: Wed, 22 Aug 2001 12:54:37 -0700 (PDT) From: Matt Dillon Message-Id: <200108221954.f7MJsbd77448@earth.backplane.com> To: Bruce Evans Cc: Terry Lambert , Jake Burkholder , John Baldwin , , Subject: Re: Preliminary proposed rollup of kernel submap initialization code References: <20010823051540.U15063-100000@besplex.bde.org> Sender: owner-freebsd-alpha@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org :Make it global in an MI section and it automatically implements it in all :platforms at once (platforms that haven't been "fixed" simply don't use it). The danger of this is that down the line someone might assume in MI code that the globals are initialized when, potentially, not all platforms initialize them. This way the MI code has no access to the global data that MD code is initializing and misuse in MI code sections will result in a compile-time error. There's nothing wrong with having MI structures that can be applied to multiple platforms but which are only used by MD routines. :> One could also argue that the mainline kernel code has no direct need to :> know about the contents of kmi but that wasn't the main reason for doing :> it that way. : :I prefer keeping the variables separate like they used to be. There is :even less need for them to be combined in a struct than there used to be, :since centralizing the their initializations ensures that they are the same :for all arches. : :Bruce All the fields are related. They belong in a structure rather then as free globals or free statics. And it makes it easier for the MD code to call the MI code. My opinion, anyway. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message