Date: Thu, 12 Mar 2020 23:06:48 +0000 From: Lorenzo Salvadore <phascolarctos@protonmail.ch> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: Alexey Dokuchaev <danfe@freebsd.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, "Tobias C. Berner" <tcberner@FreeBSD.org> Subject: Re: svn commit: r528249 - in head/emulators: i386-wine-devel wine-devel Message-ID: <PuBQZ7iLMFpJq8D7Kx-24LNZdyJkDIf-8c2vxSdQ22bR8BsCtBSYzWDefwEmsrE7ThtxCWoVbZ1MxfA_8JsFEWF8mFzkqgCti_KKMIuzk-4=@protonmail.ch> In-Reply-To: <alpine.LSU.2.21.2003122111000.4184@anthias.pfeifer.com> References: <202003111949.02BJnYIl072883@repo.freebsd.org> <20200312014556.GA10733@FreeBSD.org> <jLn9-VizONLzRI6otIUi0dKJITx_cUfZ_AcqoCwIKaYj0Z6YW2FPQdekf1Xb908ER4n0FumK9w8t2JYGQjvsa1hYA7NwsLA8E5hIHW-q9Ls=@protonmail.ch> <alpine.LSU.2.21.2003122111000.4184@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Friday 13 March 2020 00:00, Gerald Pfeifer <gerald@pfeifer.com> wrote: > On Thu, 12 Mar 2020, Lorenzo Salvadore wrote: > > > On Thursday 12 March 2020 02:45, Alexey Dokuchaev danfe@freebsd.org wro= te: > > Looks like this file should've been repocopied, but it wasn't. :-( > > Maybe it's my fault: I am still new as a committer and I might have don= e > > the renaming in the wrong way. I used "svn mv". > > Any idea how could I have done it better? > > `svn mv`, as you and me had discussed, is the right way, cf. > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/art= icle.html#svn-daily-use-copying-and-moving > > (`svn mv` is a shortcut for `svn move`, so that is not material.) > > Could it be that, in the tree you did the commit from, you ran a > regular `mv` instead of `svn mv`? I am 99% sure that I did use svn mv. > PS: Having just scanned the SVN Primer of our Committers Guide again, I > believe we should recommend running `svn status` in addition to `svn diff= ` > before every commit. The former shows file moves quite nicely. If you > don't beat me to it, I'll open a PR in the coming days... I doubt I will beat you: I have too many things to do, feel free to open th= e PR. Thanks! Lorenzo Salvadore
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?PuBQZ7iLMFpJq8D7Kx-24LNZdyJkDIf-8c2vxSdQ22bR8BsCtBSYzWDefwEmsrE7ThtxCWoVbZ1MxfA_8JsFEWF8mFzkqgCti_KKMIuzk-4=>