From nobody Fri Sep 22 21:26:57 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rslhf0sBwz4vRRf; Fri, 22 Sep 2023 21:26:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rslhf0KLTz3MwK; Fri, 22 Sep 2023 21:26:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695418018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=I0Yt0YWeEfibjmcjLoZR2cPf02REcdVrL50N6o98p6Q=; b=AbOTVebfGvxTQiFYCjz5Cnl415GKWeWy2VRLekLRlFPdkWN3wtSOWkCc03l480HPC+AAhl dfuYDibY6Z8iFSccuUnQ+eNlAHjOHcb0XNlF10W6OKCHdfBW42sdMG5DJxLtarM7u6KD38 TYhnNHu8DYBV+b4Wv9smbEzDuiV4h1o14utSjddgSG40ak3c/SOIkNWTKBny91oBSsPXq9 yuxSLinXyBKgkx4dykYrks5SvkR9ngoXbtn7xRsd3qCmeF4rLR7HMoQHlWjbE0jjjk9e6a LnrCYekwUcp++NmiV1j5n/gm7s9XpnDqi7ADiGBpAxh325QNJLYXS1kgTkQzWA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695418018; a=rsa-sha256; cv=none; b=sgcJvW0A68Ecb24Q2kay30cYN88QKz0sdXaECWfHeZDGK/8CdyhmnvIzIEpZQWm25M+TKn jHv3jcsneTLHdENV3J8mjI55pXzpDIRzM6oWq0+82vcijdJjs7YLVS3+yu3q2cjpoS+IaU KUnEJ+xWxDh419BUR56EpoiVsM9pbELzU0CKIVx67R+sD3d1hBaaqpyZ946bCitdCmwlFG pAX3TExZ0rbhH9atyTdJKk3iOcDPzwLu7yg0sw11U/ykNZqzqj32VqLmKXngEjFZuPWxb2 89mpkm7Cu6KMQiTRm7KrbF9JayvwvbHYl2nYnT2TKervkQsaF+crBn9HTFhaUg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695418018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=I0Yt0YWeEfibjmcjLoZR2cPf02REcdVrL50N6o98p6Q=; b=sGNIag2ApCEodXPS/ioLglqYDoC8EC5KRV9JIL9ggC/mRl3I+9flswZQCe+AKzm+BPdd05 aLXx6Z+fNKN3DQOfbScjc8Ms/fqDy2qRDhjk0YL22hlOQKC6lgSB2Rq52wU3zNqQWnGVXe YGfXEpzJzEiV12lyuX2FrUj6vGbe32QYcWnnsjWcFQwwy7ywynMZzTApxLFPnxwXfIdqQz CdInwjx13yZLEXKWYSwxdpexxkOsoeyX6t1lkRFyJn3lW3CopFCgj4xuwIFp5vJHGBET7H G7bHm8VypvO4hW7DbncGMFGMHR56q+hGHfQ1BJCb/u89aGdif3xpp1h98ZHwiQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rslhd6QbVzd4f; Fri, 22 Sep 2023 21:26:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38MLQvMa097188; Fri, 22 Sep 2023 21:26:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38MLQvxO097185; Fri, 22 Sep 2023 21:26:57 GMT (envelope-from git) Date: Fri, 22 Sep 2023 21:26:57 GMT Message-Id: <202309222126.38MLQvxO097185@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: 02ef039c284b - main - vfs cache: Drop known argument of internal cache_recalc_neg_min() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 02ef039c284b8a7b1ea40f5f9a851a3cb6af5b31 Auto-Submitted: auto-generated The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=02ef039c284b8a7b1ea40f5f9a851a3cb6af5b31 commit 02ef039c284b8a7b1ea40f5f9a851a3cb6af5b31 Author: Olivier Certner AuthorDate: 2023-09-22 21:25:41 +0000 Commit: Mateusz Guzik CommitDate: 2023-09-22 21:25:50 +0000 vfs cache: Drop known argument of internal cache_recalc_neg_min() 'ncnegminpct' is to be passed always, so just drop the unneeded parameter. Sponsored by: The FreeBSD Foundation Reviewed by: mjg Differential Revision: https://reviews.freebsd.org/D41763 --- sys/kern/vfs_cache.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index 0f4d7526ebb5..fdfa4fde2c07 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -990,10 +990,10 @@ SYSCTL_PROC(_vfs_cache, OID_AUTO, nchstats, CTLTYPE_OPAQUE | CTLFLAG_RD | "VFS cache effectiveness statistics"); static void -cache_recalc_neg_min(u_int val) +cache_recalc_neg_min(void) { - neg_min = (ncsize * val) / 100; + neg_min = (ncsize * ncnegminpct) / 100; } static int @@ -1012,7 +1012,7 @@ sysctl_negminpct(SYSCTL_HANDLER_ARGS) if (val < 0 || val > 99) return (EINVAL); ncnegminpct = val; - cache_recalc_neg_min(val); + cache_recalc_neg_min(); return (0); } @@ -2652,7 +2652,7 @@ nchinit(void *dummy __unused) VFS_SMR_ZONE_SET(cache_zone_large_ts); ncsize = desiredvnodes * ncsizefactor; - cache_recalc_neg_min(ncnegminpct); + cache_recalc_neg_min(); nchashtbl = nchinittbl(desiredvnodes * 2, &nchash); ncbuckethash = cache_roundup_2(mp_ncpus * mp_ncpus) - 1; if (ncbuckethash < 7) /* arbitrarily chosen to avoid having one lock */ @@ -2796,7 +2796,7 @@ cache_changesize(u_long newmaxvnodes) } } ncsize = newncsize; - cache_recalc_neg_min(ncnegminpct); + cache_recalc_neg_min(); cache_changesize_set_new(new_nchashtbl, new_nchash); cache_unlock_all_buckets(); cache_unlock_all_vnodes();