From owner-svn-ports-head@freebsd.org Thu Nov 28 19:31:16 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DB8871B4D70; Thu, 28 Nov 2019 19:31:16 +0000 (UTC) (envelope-from leres@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47P76X5Xcnz3ywv; Thu, 28 Nov 2019 19:31:16 +0000 (UTC) (envelope-from leres@freebsd.org) Received: from [192.168.0.15] (c-67-187-153-235.hsd1.ca.comcast.net [67.187.153.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: leres) by smtp.freebsd.org (Postfix) with ESMTPSA id 0D2FCBC57; Thu, 28 Nov 2019 19:31:15 +0000 (UTC) (envelope-from leres@freebsd.org) Subject: Re: svn commit: r518273 - head/comms/conserver-com To: Alexey Dokuchaev References: <201911232108.xANL825f004203@repo.freebsd.org> <20191123213729.3taj4chqdoc6vsyb@atuin.in.mat.cc> <20191125063709.GC84936@FreeBSD.org> Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Craig Leres Message-ID: <85ceb4a8-9df7-0a58-c5e0-6f144c0736a6@freebsd.org> Date: Thu, 28 Nov 2019 11:31:13 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191125063709.GC84936@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Nov 2019 19:31:16 -0000 On 11/24/2019 10:37 PM, Alexey Dokuchaev wrote: > On Sat, Nov 23, 2019 at 01:43:27PM -0800, Craig Leres wrote: >> On 2019-11-23 13:37, Mathieu Arnold wrote: >>> On Sat, Nov 23, 2019 at 09:08:02PM +0000, Craig Leres wrote: >>>> New Revision: 518273 >>>> URL:https://svnweb.freebsd.org/changeset/ports/518273 >>>> >>>> Log: >>>> comms/conserver-com: Update distinfo and remove BROKEN >>> This seems to be missing the description of the changes between the two >>> distribution files. >> >> Sorry. "Apparently github occasionally changes their software resulting >> in a change in the tarchive checksum. Update to reflect the current >> version." > > The thing is, you are expected to obtain both versions of the distfile > and compare them, explicitly asserting in the commit log that there were > no malicious changes introduced (and it they were, notify the upstream, > other distros' package maintainers, users, and general public immediately). > > This is documented in the PHB Section 13.18. When this happened, I downloaded the new tarchive and unpacked both and did a diff -r on them; the files were identical. It looked like the same files packaged in a different order. I understand now that this should have gone in the commit message. Craig