From owner-svn-ports-head@FreeBSD.ORG Sun Jul 28 19:09:40 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A7407887 for ; Sun, 28 Jul 2013 19:09:40 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7D1BD2672 for ; Sun, 28 Jul 2013 19:09:40 +0000 (UTC) Received: by mail-pd0-f170.google.com with SMTP id x10so142447pdj.1 for ; Sun, 28 Jul 2013 12:09:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=Kx2SHPofdCg0Cdjk1eBomEvSJwqABY54pa9uSAZIpJ0=; b=Bn+VrB1uOeZzZQsSbRkljp4la9bLIT2XTQSROn1RQh37naT+WqOBjEaoQ10xP6clo8 uOP0KqKOLHlPmEDMJQ+eAVNl0j45/86XwS5X5MSzas8TxizHNBVRTSvheaxkuFoHOqJJ b/yPZdq1qid2QPRIey1GTLUfY8Cky9TASg3B0XnYQhKjm/bw1Ud6j8oXvHNMkhA9kpdr tSU5sGeHh1h4+4l33qUINEMiZKkV9SQGmOcYjPcKidj42nulPcA0BdhOYfIxK4gWSMZt xfBHoVstbjx7F6FeZjNHGrY8cIX+5/3+0IadcXLMfbu9Uktp7kPW4PMwLboa7g/zO1qw fZNA== MIME-Version: 1.0 X-Received: by 10.68.254.73 with SMTP id ag9mr2547656pbd.54.1375038574546; Sun, 28 Jul 2013 12:09:34 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.70.1.226 with HTTP; Sun, 28 Jul 2013 12:09:34 -0700 (PDT) In-Reply-To: <201307281645.r6SGjNAs020031@svn.freebsd.org> References: <201307281645.r6SGjNAs020031@svn.freebsd.org> Date: Sun, 28 Jul 2013 12:09:34 -0700 X-Google-Sender-Auth: 35_rMIaM2zA-MIbJFTAVBZy9CRw Message-ID: Subject: Re: svn commit: r323836 - in head/devel: . arm-eabi-binutils arm-eabi-binutils/files From: Jason Helfman To: Tim Kientzle X-Gm-Message-State: ALoCoQkC7anjkJTOqHsAG94LZCu+86hCmWjPOqFAS7ffTqC6b3XmQkhRhO5SF0sfvWwXBCMK4KRc Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2013 19:09:40 -0000 On Sun, Jul 28, 2013 at 9:45 AM, Tim Kientzle wrote: > Author: kientzle (src committer) > Date: Sun Jul 28 16:45:22 2013 > New Revision: 323836 > URL: http://svnweb.freebsd.org/changeset/ports/323836 > > Log: > Add arm-eabi-binutils cross-tools. > > Approved by: db > > Added: head/devel/arm-eabi-binutils/Makefile > > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/arm-eabi-binutils/Makefile Sun Jul 28 16:45:22 2013 > (r323836) > @@ -0,0 +1,47 @@ > +# $FreeBSD$ > + > +PORTNAME= binutils > +PORTVERSION= 2.23.2 > +CATEGORIES= devel > +MASTER_SITES= ${MASTER_SITE_SOURCEWARE} > +MASTER_SITE_SUBDIR= binutils/releases > +PKGNAMEPREFIX= arm-eabi- > + > +MAINTAINER= kientzle@gmail.com > +COMMENT= GNU binutils for vanilla ARM cross-development > + > +.if !defined(WITHOUT_NLS) > +USE_GETTEXT= yes > +PLIST_SUB+= NLS="" > +.else > +CONFIGURE_ARGS+= --disable-nls > +PLIST_SUB+= NLS="@comment " > +.endif > +USE_BZIP2= yes > +USE_GMAKE= yes > +USES= gettext > +GNU_CONFIGURE= yes > > Is there any particular reason that bsd.port.options.mk wasn't included here? USE_GETTEXT is deprecated, and should be using the USES framework to bring in the dependency. The only reason this dependency is working is that it is unconditionally brought in with the USES framework later in the Makefile. To this affect, if NLS is disabled, it brings in gettext dependency. Can it be disabled? USE_GMAKE can be converted, as well, to the USES framework. (USES= gmake) .include .if ${PORT_OPTIONS:MNLS} USES+= gettext ... .endif Regardless, as always, thank you so much for your time and effort to work and get this inclusion into the tree, as I am sure many will benefit from it. -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serv