From owner-svn-src-all@FreeBSD.ORG Fri Mar 20 15:57:10 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15718106564A; Fri, 20 Mar 2009 15:57:10 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id BC08E8FC0A; Fri, 20 Mar 2009 15:57:09 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n2KFv8eP005017 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 20 Mar 2009 08:57:09 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <49C3BCD4.4030605@freebsd.org> Date: Fri, 20 Mar 2009 08:57:08 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.18 (X11/20081209) MIME-Version: 1.0 To: Vasil Dimov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <200903142010.n2EKAESF006945@svn.freebsd.org> <20090320140015.GA17645@hub.freebsd.org> <20090320153405.GA62675@zim.MIT.EDU> In-Reply-To: <20090320153405.GA62675@zim.MIT.EDU> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC--Metrics: ebb.errno.com; whitelist Cc: Subject: Re: svn commit: r189828 - in head: include sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2009 15:57:10 -0000 David Schultz wrote: > On Fri, Mar 20, 2009, Vasil Dimov wrote: > >> On Sat, Mar 14, 2009 at 08:10:14PM +0000, David Schultz wrote: >> >>> Author: das >>> Date: Sat Mar 14 20:10:14 2009 >>> New Revision: 189828 >>> URL: http://svn.freebsd.org/changeset/base/189828 >>> >>> Log: >>> Fix the visibility of several prototypes. Also move pthread_kill() and >>> pthread_sigmask() to signal.h. In principle, this shouldn't break anything, >>> >> [...] >> >> But it did break, see http://www.freebsd.org/cgi/query-pr.cgi?pr=132828 >> >> I think one's namespace shouldn't be polluted with the prototype of >> pthread_kill() if he has not included pthread.h. >> > > The pthreads API has always defined pthread_kill() to be in > signal.h, not pthread.h. This is what is done in glibc and > elsewhere. > > GNU Pth has some bogus and extremely unportable hacks to ``trick'' > system headers into not declaring symbols: > > /* > * Prevent system includes from implicitly including > * possibly existing vendor Pthread headers > */ > #define PTHREAD > #define PTHREAD_H > #define _PTHREAD_T > #define _PTHREAD_H > #define _PTHREAD_H_ > #define PTHREAD_INCLUDED > #define _PTHREAD_INCLUDED > #define SYS_PTHREAD_H > #define _SYS_PTHREAD_H > #define _SYS_PTHREAD_H_ > #define SYS_PTHREAD_INCLUDED > #define _SYS_PTHREAD_INCLUDED > #define BITS_PTHREADTYPES_H > #define _BITS_PTHREADTYPES_H > #define _BITS_PTHREADTYPES_H_ > #define _BITS_SIGTHREAD_H > > The one that works for glibc is _BITS_SIGTHREAD_H. I'd rather not > be complicit in these shenanigans, but if we can't easily fix the > problem in Pth, I suppose we can teach signal.h about one of these > bogus macros. What do you think? > > Dumb question, why do we need devel/pth? Isn't the native pthread support sufficient? Sam