From owner-cvs-src@FreeBSD.ORG  Mon Feb 16 16:18:35 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9B24616A4CF; Mon, 16 Feb 2004 16:18:35 -0800 (PST)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9686643D1D; Mon, 16 Feb 2004 16:18:35 -0800 (PST)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 925BC5C771; Mon, 16 Feb 2004 16:18:35 -0800 (PST)
Date: Mon, 16 Feb 2004 16:18:35 -0800
From: Alfred Perlstein <alfred@freebsd.org>
To: Dag-Erling Smorgrav <des@FreeBSD.org>
Message-ID: <20040217001835.GE55055@elvis.mu.org>
References: <200402161841.i1GIfwmv008267@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200402161841.i1GIfwmv008267@repoman.freebsd.org>
User-Agent: Mutt/1.4.2i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/vm vm_kern.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Feb 2004 00:18:35 -0000

* Dag-Erling Smorgrav <des@FreeBSD.org> [040216 10:41] wrote:
> des         2004/02/16 10:41:58 PST
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/vm               vm_kern.c 
>   Log:
>   Don't panic if we fail to satisfy an M_WAITOK request; return 0 instead.
>   The calling code will either handle that gracefully or cause a page fault.

This is really bad idea, please back it out.  You are certainly
going to get a pagefault in virtually EVERY consumer of malloc.  It
turns easy to debug calls into a "page fault" ie. "buggy" looking
kernel.

Bad press, bad idea, back it out, no cookie. :(

You go from:
  "I installed freebsd, exhausted some limits and the machine blew."
to:
  "FreeBSD falls over with 'random' panics when faced with large load."

-- 
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684