From owner-freebsd-arm@freebsd.org Thu Dec 17 13:10:40 2015 Return-Path: Delivered-To: freebsd-arm@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3384A4ACD9 for ; Thu, 17 Dec 2015 13:10:40 +0000 (UTC) (envelope-from onwahe@gmail.com) Received: from mail-io0-x235.google.com (mail-io0-x235.google.com [IPv6:2607:f8b0:4001:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7669E11A6; Thu, 17 Dec 2015 13:10:40 +0000 (UTC) (envelope-from onwahe@gmail.com) Received: by mail-io0-x235.google.com with SMTP id 186so55131194iow.0; Thu, 17 Dec 2015 05:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=LRPpyZKBEV+/7L8ER/GBdiG+xQAHG7EScepVj5ddasU=; b=HuAAShr7qRTd2ggGOXDitDnRTlE/437RRrP10C3ZZRBE0IZ7Umdejb+cLdpbrP9qat aY3vQ0UTbXwHjF7iezsCcC4c7E2K7oxofZPTXDhk+nw4HDhTTo/lP4NtkqWpsoKhSBAz /NFDRe6WQWvre4xEwckM8zy8quOnSEeXRbMG500faMn+q7iwXKpqbJYqynA+eZLdG8i1 TRotrOdOCiee7+JOxmWsso+Zrf97B6B7ojeCGb/9RYxwzC7rOfjY8CFYJWTwnbP8/5KV SwTF9B7YJzfgc99+o8jX2M9BWqCkigKOwZaNC2JNXneM6wYfyl9vgW3N277VGefnmjxE kh+g== MIME-Version: 1.0 X-Received: by 10.107.26.83 with SMTP id a80mr22319577ioa.30.1450357839839; Thu, 17 Dec 2015 05:10:39 -0800 (PST) Received: by 10.64.130.38 with HTTP; Thu, 17 Dec 2015 05:10:39 -0800 (PST) In-Reply-To: References: Date: Thu, 17 Dec 2015 14:10:39 +0100 Message-ID: Subject: Re: RFC: migrate arm/arm/intrng.c -> kern/subr_intr.c in prep for MIPS using it From: Svatopluk Kraus To: Adrian Chadd Cc: "freebsd-arm@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2015 13:10:40 -0000 Just some suggestions about renaming. arm_irqsrc -> intr_src or intr_source ARM_ISRCT_xyz -> INTR_SRCT_xyz ARM_ISRCF_xyz -> INTR_SRCF_xyz ARM_ISRC_NAMELEN -> INTR_SRC_NAMELEN sys/arm/arm/machdep_intr.c ... remove unneeded headers? sys/conf/files.arm ... rename arm_intrng option And FYI, the framework needs some more love. Svata On Thu, Dec 17, 2015 at 9:07 AM, Adrian Chadd wrote: > Hi, > > kan@ has been working on bringing in support for the CI20 board - > where he used the arm intrng code in his mips port. > > So, I figured it is a good time to migrate the arm code into a generic > spot to be reused. > > Here's my initial port: > > http://people.freebsd.org/~adrian/arm/20151216-arm-intrng-generic-1.diff > > It: > > * moves the machdep bits into a separate file (arm/arm/machdep_intr.c); > * move intrng.c into sys/kern/subr_intr.c; > * rename the ARM_ -> INTR_, and arm_ -> intr_ symbols; > * fix up a variety of consumers of said code. > > It's a WIP - I plan on doing the minimum needed to put it there so we > can use the code for other ports, and not try to solve the "how do we > integrate this cleanly into the existing interrupt code" problem. > > This intr sharing code should make kan's job a lot easier. :) > > Thanks! > > > -a > _______________________________________________ > freebsd-arm@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org"