From owner-cvs-src@FreeBSD.ORG Mon Dec 6 19:16:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F10E16A4CE; Mon, 6 Dec 2004 19:16:09 +0000 (GMT) Received: from visp.engelschall.com (visp.engelschall.com [195.27.176.148]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8FA4843D66; Mon, 6 Dec 2004 19:16:08 +0000 (GMT) (envelope-from rse@engelschall.com) Received: by visp.engelschall.com (Postfix, from userid 1005) id 750E34CE56B; Mon, 6 Dec 2004 20:16:09 +0100 (CET) Received: by en1.engelschall.com (Postfix, from userid 10000) id 0AD7DA17CF; Mon, 6 Dec 2004 20:15:50 +0100 (CET) Date: Mon, 6 Dec 2004 20:15:50 +0100 From: "Ralf S. Engelschall" To: Mike Makonnen Message-ID: <20041206191549.GA38708@engelschall.com> References: <200412052145.iB5LjbRD019745@repoman.freebsd.org> <20041206112604.GA5825@rogue.acs.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041206112604.GA5825@rogue.acs.lan> User-Agent: Mutt/1.4.2.1i Organization: Engelschall, Germany. X-Web-Homepage: http://www.engelschall.com/ X-PGP-Public-Key: http://www.engelschall.com/ho/rse/pgprse.asc X-PGP-Fingerprint: 00 C9 21 8E D1 AB 70 37 DD 67 A2 3A 0A 6F 8D A5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Pawel Jakub Dawidek cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc network.subr X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: rse@engelschall.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Dec 2004 19:16:09 -0000 On Mon, Dec 06, 2004, Mike Makonnen wrote: > On Sun, Dec 05, 2004 at 09:45:37PM +0000, Pawel Jakub Dawidek wrote: > > pjd 2004-12-05 21:45:37 UTC > > > > FreeBSD src repository > > > > Modified files: > > etc network.subr > > Log: > > 'all' argument for list_net_interfaces() is now unused, remove it. > > The 'all' argument is in 5-STABLE, and is therefore a public interface now. > We may not use it at the moment, but not having it in 6.X (when *it* goes > -stable) will be gratuitously breaking API for any third parties that may > be using it. Please put it back. Are you sure? I cannot see where this should be present in 5-STABLE (RELENG_5)? Pawel added it just recently to CURRENT (HEAD)'s network.subr in order to support the ifnet_rename() function. 5-STABLE's network.subr doesn't contain this. I think you are intermixing this with the fact that if list_net_interfaces() is called _without any_ arguments, it (still) does a similar thing than the removed "all". This functionality was not touched here. Pawel just removed the explicit "all" feature which had output a little bit more than the current no-argument usage. Ralf S. Engelschall rse@engelschall.com www.engelschall.com