From owner-freebsd-ports@FreeBSD.ORG Thu Jul 21 01:32:25 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8DC2A106564A for ; Thu, 21 Jul 2011 01:32:25 +0000 (UTC) (envelope-from stephen@missouri.edu) Received: from wilberforce.math.missouri.edu (wilberforce.math.missouri.edu [128.206.184.213]) by mx1.freebsd.org (Postfix) with ESMTP id 582418FC13 for ; Thu, 21 Jul 2011 01:32:24 +0000 (UTC) Received: from [127.0.0.1] (wilberforce.math.missouri.edu [128.206.184.213]) by wilberforce.math.missouri.edu (8.14.4/8.14.4) with ESMTP id p6L1WNc1017659; Wed, 20 Jul 2011 20:32:24 -0500 (CDT) (envelope-from stephen@missouri.edu) Message-ID: <4E2781A7.9060703@missouri.edu> Date: Wed, 20 Jul 2011 20:32:23 -0500 From: Stephen Montgomery-Smith User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 MIME-Version: 1.0 To: Joe Marcus Clarke References: <4E273D4C.6060105@missouri.edu> <4E277370.8080206@freebsd.org> In-Reply-To: <4E277370.8080206@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: FreeBSD Ports Subject: Re: portlint: DATADIR and NOEXAMPLEDOCS X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2011 01:32:25 -0000 On 07/20/2011 07:31 PM, Joe Marcus Clarke wrote: > On 7/20/11 4:40 PM, Stephen Montgomery-Smith wrote: >> I have a couple of questions. >> >> 1) Why does portlint complain if a port is not DATADIR compliant? > > The warning is very conditional. It tries to provide information so one > can make an informed decision as to whether or not they want to be > DATADIR-safe. > >> >> What was the rationale behind making ports DATADIR compliant, so that if >> one types "make install DATADIR=/somewhere_else" then what would be >> stored in /usr/local/share/port_name will now be in /somewhere_else. >> >> If there are one hundred ports depending upon port x/y, and those ports >> use the x/y DATADIR, then each of those hundred ports will have to include: >> DATADIR!= cd ${.CURDIR}/../../x/y&& make -V DATADIR > > This doesn't make sense for all ports. That's why the warning is soft. > >> >> This will really slow down makeindex. >> >> It seems to me that you cannot use: >> DATADIR= `cd ${.CURDIR}/../../x/y&& make -V DATADIR` >> because this won't properly set PLIST_SUB. >> >> 2) Why does portlint NOT complain if a port is not NOPORTEXAMPLES >> compliant? > > No one asked for it. > >> >> This would seem a natural extension of portlint complaining if a port is >> not NOPORTDOCS compliant. > > I agree. Patches welcome. > Thanks. Those are both good answers. I'll look into a patch for NOPORTEXAMPLES, but the code is definitely quite involved, and I can now see it will be a little bit more work than "monkey see - monkey do."