From owner-svn-ports-head@FreeBSD.ORG Fri Jan 23 17:05:25 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5219D617 for ; Fri, 23 Jan 2015 17:05:25 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 16B1F1B2 for ; Fri, 23 Jan 2015 17:05:25 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t0NH5OLp029916 for ; Fri, 23 Jan 2015 17:05:24 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t0NH5OC1029911 for svn-ports-head@freebsd.org; Fri, 23 Jan 2015 17:05:24 GMT (envelope-from bdrewery) Received: (qmail 83285 invoked from network); 23 Jan 2015 11:05:22 -0600 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 23 Jan 2015 11:05:22 -0600 Message-ID: <54C27F61.7020606@FreeBSD.org> Date: Fri, 23 Jan 2015 11:05:37 -0600 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: svn commit: r377696 - head/Mk/Scripts References: <201501222105.t0ML5q3U010699@svn.freebsd.org> <20150123071820.GB70500@FreeBSD.org> In-Reply-To: <20150123071820.GB70500@FreeBSD.org> OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="424mn0FSHSONgSkIoi3JQugBK8LLc3Kbn" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 17:05:25 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --424mn0FSHSONgSkIoi3JQugBK8LLc3Kbn Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 1/23/2015 1:18 AM, Alexey Dokuchaev wrote: > On Thu, Jan 22, 2015 at 09:05:52PM +0000, Bryan Drewery wrote: >> New Revision: 377696 >> URL: https://svnweb.freebsd.org/changeset/ports/377696 >> QAT: https://qat.redports.org/buildarchive/r377696/ >> >> Log: >> Don't replace PREFIX anywhere in the plist line, only do it for the >> beginning. >> [...] >> - sed_files_gen=3D"s!${PREFIX}/!!g; ${sed_plist_sub} \ >> + sed_files_gen=3D"s!^${PREFIX}/!!g; ${sed_plist_sub} \ >=20 > So why global modifiers are being used? (TBH, they are being abused a = lot > in ports. It seems that folks just throw them in by default without gi= ving > it much thinking.) >=20 > ./danfe >=20 I missed that, will review to see why it was there. --=20 Regards, Bryan Drewery --424mn0FSHSONgSkIoi3JQugBK8LLc3Kbn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUwn9hAAoJEDXXcbtuRpfPrDcIAM0DVdT40oJTLYEPFoNzkjsi u99DeTXNptDgxbVJSwtSljEkaTUQCBvKzCM2lyJRJj3EV9tE9Wj5p8objFNaNzUl dR3SOHgoUjOMdbbq8BAPqyEp7z8XvDp4cxnQbSR5YL86yw3OT0io9t8MrD577Hxl Bkk18S/R+3hfO6tRx0H6kXgu8LhBC5i6V24vxhpuMJzyMFKGyS14q4KmjgeTYNCD ZVyZh1s1qvxb1a28MwEnqJbalmsAw9Hlkhvnc4NP23j9JuiuRE1KmhTinU0ASnyn LG7LNiayp0Hp+1Gap3U/K8bt4OObrxkcUQrp3x4jClYrsO6l29KmMaoNqkFHdEg= =4n9I -----END PGP SIGNATURE----- --424mn0FSHSONgSkIoi3JQugBK8LLc3Kbn--