From owner-freebsd-mobile  Thu Jan 27  0:56:41 2000
Delivered-To: freebsd-mobile@freebsd.org
Received: from tasogare.imasy.or.jp (tasogare.imasy.or.jp [202.227.24.5])
	by hub.freebsd.org (Postfix) with ESMTP id 8EB5C15067
	for <freebsd-mobile@FreeBSD.ORG>; Thu, 27 Jan 2000 00:56:38 -0800 (PST)
	(envelope-from iwasaki@jp.FreeBSD.org)
Received: from localhost (isdn33.imasy.or.jp [202.227.24.225])
	by tasogare.imasy.or.jp (8.9.3+3.2W/3.7W-tasogare/smtpfeed 1.01) with ESMTP id RAA07853;
	Thu, 27 Jan 2000 17:56:31 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
Message-Id: <200001270856.RAA07853@tasogare.imasy.or.jp>
To: imp@village.org
Cc: iwasaki@jp.FreeBSD.org, gallatin@cs.duke.edu,
	freebsd-mobile@FreeBSD.ORG
Subject: Re: pc card removal lockup 
In-Reply-To: Your message of "Thu, 27 Jan 2000 01:24:27 -0700"
	<200001270824.BAA43895@harmony.village.org>
References: <200001270824.BAA43895@harmony.village.org>
X-Mailer: Mew version 1.93 on Emacs 19.34 / Mule 2.3 (SUETSUMUHANA)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Date: Thu, 27 Jan 2000 17:56:26 +0900
From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
X-Dispatcher: imput version 980905(IM100)
Lines: 38
Sender: owner-freebsd-mobile@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Hi,

> Hi isasaki-san,

# my name is iwasaki :)

> In message <200001270436.NAA03328@tasogare.imasy.or.jp> Mitsuru IWASAKI writes:
> : I thought that delay by disable_slot_spl0() cause some sort of race
> : condition and miss an interrupt as result...
> : I'm testing this patch and seem to solve the problem for my
> : environment so far.
> 
> OK.  IF that solves the problem, then what about this patch?  It is
> the same as yours, except it also garbage collects the unused code.
> Getting rid of the spl0 code was on my list (since bruce pointed out
> to me that it wasn't really running at spl0), but I wasn't motivated
> until now to try to track it down.

I basically agree with you.  I have two things to say.

How about adding splhigh() and splx() around calling disable_slot() as
same as pccard_suspend()?  It will make removal event handling more
safty, I beleave.

And Is disable_slot_to() necessary if we don't use spl0 code?
I think calling disable_slot() would be almost the same as the code in
pccard_suspend().

# I'm sorry, no time to make pactch...

> I also included removing the PCIC_RESUME_RESET option, at least
> partially.  Users that have problems with resume reset can set it in
> their sysctl.conf file to be off.  No need for both an option and a
> sysctl.  It is whole contained in the first chunk of the diff.

Agreed.

Thanks Warner-san.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message