From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:45:16 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9ECF4D36 for ; Tue, 17 Feb 2015 17:45:16 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 80E88826 for ; Tue, 17 Feb 2015 17:45:16 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHjGbc098638 for ; Tue, 17 Feb 2015 17:45:16 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHjG9U098637; Tue, 17 Feb 2015 17:45:16 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:45:16 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 39 lines] D1880: Prevent creation of an invalid nvlist Message-ID: X-Priority: 3 Thread-Topic: D1880: Prevent creation of an invalid nvlist X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: NDc0MzY1NWE0OGUwMDY2MmUyOTI4NDYxZjhl X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:45:16 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION SUMMARY If an nvlist is set as a child of another nvlist with nvlist_move_nvlist then fail the operation and set the parent nvlist to the error state. REVISION DETAIL https://reviews.freebsd.org/D1880 AFFECTED FILES lib/libnv/nvpair.c lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd