Date: 25 Jan 2006 13:02:41 -0200 From: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: chuck@pkix.net, pav@FreeBSD.org Subject: ports/92315: [patch:fix] sysutils/dvd+rw-tools : thread problems: build typo and hard coded build options Message-ID: <20060125150304.31953.qmail@exxodus.fedaykin.here> Resent-Message-ID: <200601251510.k0PFA3WM014981@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 92315
>Category: ports
>Synopsis: [patch:fix] sysutils/dvd+rw-tools : thread problems: build typo and hard coded build options
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Jan 25 15:10:03 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Mario Sergio Fujikawa Ferreira
>Release: FreeBSD 6.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD exxodus.home.here 6.0-STABLE FreeBSD 6.0-STABLE #8: Fri Jan 20 02:20:43 BRST 2006 lioux@exxodus:/usr/obj-6.x/usr/src-6.x/sys/LIOUX i386
>Description:
o dvd+rw-tools Makefile uses an incorrect compile time macro due
to a typo. It should be using -D_THREAD_SAFE instead of -DTHREAS_SAFE
o Futhermore, make sure the port upholds PTHREAD_{CFLAGS,LIBS}
o Bump PORTREVISION to make users update
>How-To-Repeat:
>Fix:
--- patch-Makefile begins here ---
--- Makefile.orig Wed Jan 25 09:44:41 2006
+++ Makefile Wed Jan 25 12:55:27 2006
@@ -6,7 +6,7 @@
PORTNAME= dvd+rw-tools
PORTVERSION= 6.0
-PORTREVISION= 1
+PORTREVISION= 2
CATEGORIES= sysutils
MASTER_SITES= http://www.pkix.net/mirror/fy.chalmers.se/ \
http://fy.chalmers.se/~appro/linux/DVD+RW/tools/
@@ -25,7 +25,12 @@
PORTDOCS= index.html
post-patch:
- ${REINPLACE_CMD} -e 's/-O2//' ${WRKSRC}/Makefile.m4
+ ${REINPLACE_CMD} \
+ -e 's/-D_THREAS_SAFE/-D_THREAD_SAFE/' \
+ -e 's/-D_THREAD_SAFE/-D_THREAD_SAFE ${PTHREAD_CFLAGS}/' \
+ -e 's/-pthread/${PTHREAD_LIBS}/' \
+ -e 's/-O2//' \
+ ${WRKSRC}/Makefile.m4
do-install:
.for i in ${BIN_FILES}
--- patch-Makefile ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060125150304.31953.qmail>