Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Aug 2021 22:41:53 GMT
From:      Scott Long <scottl@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 35547df5c786 - main - Call wakeup() with the lock held to avoid missed wakeup races.
Message-ID:  <202108102241.17AMfr63025604@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by scottl:

URL: https://cgit.FreeBSD.org/src/commit/?id=35547df5c78653b2da030f920323c0357056099f

commit 35547df5c78653b2da030f920323c0357056099f
Author:     Scott Long <scottl@FreeBSD.org>
AuthorDate: 2021-08-10 22:36:38 +0000
Commit:     Scott Long <scottl@FreeBSD.org>
CommitDate: 2021-08-10 22:36:38 +0000

    Call wakeup() with the lock held to avoid missed wakeup races.
    
    Submitted by: luiz
    Sponsored by: Rubicon Communications, LLC ("Netgate")
---
 sys/dev/sdhci/sdhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/sdhci/sdhci.c b/sys/dev/sdhci/sdhci.c
index d075c2e05000..573e6949b57e 100644
--- a/sys/dev/sdhci/sdhci.c
+++ b/sys/dev/sdhci/sdhci.c
@@ -2078,8 +2078,8 @@ sdhci_generic_release_host(device_t brdev __unused, device_t reqdev)
 	/* Deactivate led. */
 	WR1(slot, SDHCI_HOST_CONTROL, slot->hostctrl &= ~SDHCI_CTRL_LED);
 	slot->bus_busy--;
-	SDHCI_UNLOCK(slot);
 	wakeup(slot);
+	SDHCI_UNLOCK(slot);
 	return (0);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202108102241.17AMfr63025604>