Date: Thu, 06 Dec 2018 09:16:51 -0400 From: Joseph Mingrone <jrm@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r486753 - head/cad/gmsh Message-ID: <86mupissl8.fsf@phe.ftfl.ca> In-Reply-To: <20181206121214.GA23700@FreeBSD.org> (Alexey Dokuchaev's message of "Thu, 6 Dec 2018 12:12:14 %2B0000") References: <201812061155.wB6Bt0hZ079960@repo.freebsd.org> <20181206121214.GA23700@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain Alexey Dokuchaev <danfe@freebsd.org> writes: > On Thu, Dec 06, 2018 at 11:55:00AM +0000, Joseph Mingrone wrote: >> New Revision: 486753 >> URL: https://svnweb.freebsd.org/changeset/ports/486753 >> Log: >> cad/gmsh: Update to 4.0.6 >> Upstream change log: >> https://gitlab.onelab.info/gmsh/gmsh/blob/master/CHANGELOG.txt >> -BROKEN_FreeBSD_12_i386= fails to build on FreeBSD 12 i386 due to a clang bug: https://llvm.org/bugs/show_bug.cgi?id=21903 >> -BROKEN_FreeBSD_13_i386= fails to build on FreeBSD 13 i386 due to a clang bug: https://llvm.org/bugs/show_bug.cgi?id=21903 > It would be nice to explicitly acknowledge in the commit log that it builds > fine on i386 now, and these lines were not removed by accident. >> -MAKE_JOBS_UNSAFE= yes >> - > I didn't find anything about parallel build fixes in the changelog, and > commit message does not mention it as well. It is expected that when -jX > unsafe issue it fixed (and thus MAKE_JOBS_UNSAFE removed), an approximate > explanation is provided in the commit log. People often try parallel > builds locally and they seem fine, while the problem might just not so > easily manifest itself. > ./danfe I agree in both cases that the commit log fell short. This was careless on my part, so pointy hat to me. According to the submitter (see the referenced PR, 233618), he tested this in poudriere and the build now succeeds on 12/13 i386. As for the removal of MAKE_JOBS_UNSAFE=yes, again, this should have been documented by both the submitter and me. However, given it was added over 5 years ago and PR 182125 says 'How-To-Repeat: Build on a MP machine', I am inclined to leave things as they are for now. -- Joseph --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEVbCTpybDiFVxIrrVNqQMg7DW754FAlwJIUNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUACgkQNqQMg7DW 754ijA/8DeWAwe5ljBVez5EviYpyAWwXPGJgXZSH3EiohfBz1KQbzLUzNPN7gMT0 EWWNkoXfA13JK+LMmVkgC3X4lyIfi9bl57chCpQcUcCSIjOlU10MJlIgTdvU2SSj 3u2uZNSDIfc8KqHnph5D7KmJ/raMvFtIomwUquO96NojzvQg5SnGW0r4/tU8kH64 /7y98t13ZmVhIjKclHP8LtKrXUMksK6uZdGFX2vTNSksVCEdB8RAIvudG6AJL4qb S45l8vU2oM/jEfXZ5LdU5IUpflrVNsikPZe7Z5guWJclGPXK79CSE4fngk3ziX+I mziVsObwsBvpKiuju0GdWUh12un78kI8PB1RnMdHJy9zmfmRgJZ2YOYv42aN7aWY aQnA2GJ1HrLaLZUNWT00sSoJT23l5mzk4bpo3X4UpoonBL/iY1Tj0CGsxhD3Eu97 0IDyVILQwupGMqcwUIp46w9nLEjDCdrNeQUMlxjvAdAha5opzF8CUhxgoG/Vz/p2 KRShcPKCnYmrDP7qLsGyV8q7SNzKZxihTGzW5aFfTiWAmoiXUXNWDH8meAfJae73 uDQ46uoLd9WIt9649Eanj5NTF1uAMVZVYnYlxNTYCTmQSlRcjRjosnOTOhdBVcbY iGKMlkJRIUriKHt2kAmYw7Lom+a8RuXYnhChdtmVWmIBdTXAIJw= =klS/ -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86mupissl8.fsf>