From owner-cvs-all@FreeBSD.ORG Sat Jan 17 13:29:21 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BE0B16A4CE; Sat, 17 Jan 2004 13:29:21 -0800 (PST) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF44C43D45; Sat, 17 Jan 2004 13:29:19 -0800 (PST) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.12.9p2/8.12.9) with ESMTP id i0HLT97E051788; Sat, 17 Jan 2004 13:29:13 -0800 (PST) (envelope-from truckman@FreeBSD.org) Message-Id: <200401172129.i0HLT97E051788@gw.catspoiler.org> Date: Sat, 17 Jan 2004 13:29:09 -0800 (PST) From: Don Lewis To: phk@phk.freebsd.dk In-Reply-To: <76966.1074373420@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/pci neomagic-coeff.h src/sys/dev/sound/pcm dsp.c mixer.c sound.c sound.h vchan.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jan 2004 21:29:21 -0000 On 17 Jan, Poul-Henning Kamp wrote: > In message <200401171115.i0HBFC7E048300@gw.catspoiler.org>, Don Lewis writes: > >>> Log: >>> As previously announced: discontinue use of makedev() call in soundcode. >>> >> >>Sigh ... I predict hours of entertainment merging this with my pcm/* >>buffer overflow and locking cleanup patch. > > First of all, I doubt there is much cross-section there, second, this > patch has been posted twice and I do not recall any email from you > on that subject. I haven't looked at your changes, so it is possible that our patches avoided each other, though I do remember seeing makedev() near some of the places that I touched. My patch file has grown to about 1000 lines and has been posted to current@ a number of times in the last week or so. I only landed in the sound code in the last few weeks and only because that's where I tracked a heap-eating buffer overflow. I didn't even have working sound hardware until a day or so ago, so tracking sound issues has not been a priority for me. Your changes sound like they are the way forward, so I don't have a problem with them being committed. It's just that the timing is unfortunate that we have both been making some large changes to the same subsystem at the same time. I really want to burn all my sound hardware after I'm done with my fixes.