From owner-svn-src-all@freebsd.org Thu Nov 22 13:17:29 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8CDEC114875D; Thu, 22 Nov 2018 13:17:29 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0DA80764AA; Thu, 22 Nov 2018 13:17:29 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 9EF10BEFF; Thu, 22 Nov 2018 13:17:28 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf1-f48.google.com with SMTP id f23so6496814lfc.13; Thu, 22 Nov 2018 05:17:28 -0800 (PST) X-Gm-Message-State: AGRZ1gLq34GWfYlJYwX/7Pf4Bqhypqy1toxQ0lreGRiUg4vK7eRxDHb5 VhhynQjrXXoMd9B92Aug60BYk8IeClTA5XLJtLo= X-Google-Smtp-Source: AJdET5fVBKOnFJ8oEVYZhiEOjGeTe9Lmdzc3aMQCdQxSkykVJxFtN/XF0z3P/E2a7t0G1/L4sAFS/wWSCjdUMGhHunQ= X-Received: by 2002:a19:c70a:: with SMTP id x10mr6362543lff.88.1542892647062; Thu, 22 Nov 2018 05:17:27 -0800 (PST) MIME-Version: 1.0 References: <201810210208.w9L28vVc080088@repo.freebsd.org> <20181122071629.GA96830@raichu> In-Reply-To: <20181122071629.GA96830@raichu> From: Kyle Evans Date: Thu, 22 Nov 2018 07:17:15 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r339516 - head/sys/cddl/dev/dtrace/powerpc To: Mark Johnston Cc: Justin Hibbits , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Li-Wen Hsu Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0DA80764AA X-Spamd-Result: default: False [1.01 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_SHORT(0.09)[0.091,0]; NEURAL_SPAM_MEDIUM(0.54)[0.538,0]; NEURAL_SPAM_LONG(0.38)[0.383,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 13:17:29 -0000 On Thu, Nov 22, 2018 at 1:16 AM Mark Johnston wrote: > > On Wed, Nov 21, 2018 at 10:02:15PM -0600, Kyle Evans wrote: > > On Wed, Nov 21, 2018 at 9:42 PM Kyle Evans wrote: > > > > > > On Sat, Oct 20, 2018 at 9:09 PM Justin Hibbits wrote: > > > > > > > > Author: jhibbits > > > > Date: Sun Oct 21 02:08:57 2018 > > > > New Revision: 339516 > > > > URL: https://svnweb.freebsd.org/changeset/base/339516 > > > > > > > > Log: > > > > powerpc/dtrace: Use explicit bit numbers to mask out PSL_EE > > > > > > > > There seems to be a race in CI, such that dtrace_asm.S might be assembled > > > > before the genassym is completed. This causes a build failure when PSL_EE > > > > doesn't exist, and is read as 0. Get around this by explicitly specifying > > > > the bits in the mask instead. > > > > > > > > > > Hi, > > > > > > CI on the stable/12 branch still hits this, so I'm tempted to MFC this > > > if you don't object. OTOH, the correct solution should be a > > > `dependency "genassym.o"` in ^/sys/conf/files.powerpc for > > > dtrace_asm.S, no? > > I believe that dtrace_asm.S will be built as part of dtrace.ko, not the > kernel. dtrace/Makefile already specifies a dependency on assym.inc. > Maybe this is the same issue as PR 233339? > Ah, indeed, this was the module rather than kernel build of dtrace_asm.S -- sorry about that. That one is indeed not as simple of a fix. =(