From owner-cvs-src@FreeBSD.ORG Mon Jan 14 22:46:44 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3CB116A496; Mon, 14 Jan 2008 22:46:44 +0000 (UTC) (envelope-from kris@FreeBSD.org) Received: from weak.local (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AB89513C4CC; Mon, 14 Jan 2008 22:46:42 +0000 (UTC) (envelope-from kris@FreeBSD.org) Message-ID: <478BE651.1020901@FreeBSD.org> Date: Mon, 14 Jan 2008 23:46:41 +0100 From: Kris Kennaway User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: Kris Kennaway , obrien@FreeBSD.ORG, Tim Kientzle , Tim Kientzle , Dag-Erling Smorgrav , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> <478AA9E4.2010807@kientzle.com> <478ABC4B.8080601@FreeBSD.org> <20080114181154.GA2286@dragon.NUXI.org> <478BC55B.2060202@FreeBSD.org> <20080114223239.GC56062@VARK.MIT.EDU> In-Reply-To: <20080114223239.GC56062@VARK.MIT.EDU> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 22:46:45 -0000 David Schultz wrote: > On Mon, Jan 14, 2008, Kris Kennaway wrote: >> David O'Brien wrote: >> >>>> If we have to special case ports to deal with variant zipfiles that >>>> cannot be processed by /usr/bin/unzip then it gets messier because we >>>> have to account for some ports being satisfied with USE_ZIP=yes meaning >>>> /usr/bin/unzip and some still requiring /usr/ports/archivers/unzip. I'd >>>> prefer not to have to add those workarounds. >>> This seems quite easy... >>> >>> For those four-ish ports 's/USE_ZIP/USE_INFOZIP/' >> That's what I meant by "special case". I don't like adding special case >> variables to bsd.*.mk for the benefit of a tiny number of ports; that >> file is already cluttered enough. > > Given how little time it took Tim to get libarchive from a simple > prototype that supported tar files to a 23k line library that > supports dozens of variant archive formats, I suspect that the > limitation and the corresponding hack will be temporary. :) And if > it is just a small number of ports, it could be set up as an > extract dependency in the individual port makefiles, right? It's > not as though InfoZIP is going to change a lot in the near future. > > No, you'd have to duplicate the do-extract code (or add a special variable for those 4 ports). I'd much rather wait to see what Tim and Dag-Erling can come up with. Kris