From owner-svn-src-all@FreeBSD.ORG Thu Jun 11 04:04:37 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A9F0C106564A; Thu, 11 Jun 2009 04:04:37 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail02.syd.optusnet.com.au (mail02.syd.optusnet.com.au [211.29.132.183]) by mx1.freebsd.org (Postfix) with ESMTP id 2A0C58FC08; Thu, 11 Jun 2009 04:04:36 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c122-106-159-184.carlnfd1.nsw.optusnet.com.au (c122-106-159-184.carlnfd1.nsw.optusnet.com.au [122.106.159.184]) by mail02.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id n5B44WNa024845 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 11 Jun 2009 14:04:34 +1000 Date: Thu, 11 Jun 2009 14:04:32 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: John Baldwin In-Reply-To: <200906101442.20988.jhb@freebsd.org> Message-ID: <20090611135433.K21177@delplex.bde.org> References: <200906101827.n5AIRFoR022115@svn.freebsd.org> <200906101442.20988.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r193941 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2009 04:04:38 -0000 On Wed, 10 Jun 2009, John Baldwin wrote: > On Wednesday 10 June 2009 2:27:15 pm John Baldwin wrote: >> Author: jhb >> Date: Wed Jun 10 18:27:15 2009 >> New Revision: 193941 >> URL: http://svn.freebsd.org/changeset/base/193941 >> >> Log: >> Change a few members of tcpcb that store cached copies of ticks to be ints >> instead of unsigned longs. This fixes a few overflow edge cases on 64-bit >> platforms. Specifically, if an idle connection receives a packet shortly >> before 2^31 clock ticks of uptime (about 25 days with hz=1000) and the keep >> alive timer fires after 2^31 clock ticks, the keep alive timer will think >> that the connection has been idle for a very long time and will immediately >> drop the connection instead of sending a keep alive probe. >> >> Reviewed by: silby, gnn, lstewart >> MFC after: 1 week > > Note that the MFC patch for 7 is very different. I can't change the members > to int in 7 since tcpcb is part of the ABI (for netstat, etc.). So, for 7 I > added explicit casts in the math operations using t_rcvtime and ticks. That has a better chance of working too. Bruce